Skip to content

Conversation

@hust-hhb
Copy link
Contributor

pick:#47666

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hust-hhb hust-hhb requested a review from dataroaring as a code owner March 14, 2025 09:51
@hust-hhb
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Mar 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 40283 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1d0a6416bfd1baeeec2a78325ccf215a77df4476, data reload: false

------ Round 1 ----------------------------------
q1	17574	6767	6533	6533
q2	2059	177	157	157
q3	10556	1107	1141	1107
q4	10929	731	732	731
q5	7968	2925	2847	2847
q6	223	144	133	133
q7	990	635	614	614
q8	9391	1965	2026	1965
q9	6766	6509	6506	6506
q10	8060	2334	2329	2329
q11	467	266	271	266
q12	399	219	213	213
q13	17787	2999	3022	2999
q14	259	207	208	207
q15	504	470	455	455
q16	644	590	588	588
q17	969	574	515	515
q18	7424	6828	6725	6725
q19	1416	1047	1032	1032
q20	482	200	192	192
q21	4063	3184	3188	3184
q22	1056	1009	985	985
Total cold run time: 109986 ms
Total hot run time: 40283 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6580	6576	6537	6537
q2	323	231	229	229
q3	2896	2873	3057	2873
q4	2070	1830	1797	1797
q5	5987	5921	5817	5817
q6	209	129	133	129
q7	2237	1867	1911	1867
q8	3435	3490	3496	3490
q9	8934	8870	8926	8870
q10	3582	3565	3515	3515
q11	584	496	509	496
q12	811	625	613	613
q13	6291	3193	3099	3099
q14	293	275	272	272
q15	517	479	480	479
q16	669	644	647	644
q17	1834	1617	1612	1612
q18	8302	7709	7782	7709
q19	1730	1556	1558	1556
q20	2045	1807	1775	1775
q21	5318	4985	5238	4985
q22	1078	1028	991	991
Total cold run time: 65725 ms
Total hot run time: 59355 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190694 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1d0a6416bfd1baeeec2a78325ccf215a77df4476, data reload: false

query1	972	367	353	353
query2	6519	2048	1999	1999
query3	6708	214	221	214
query4	33953	23308	23320	23308
query5	4335	465	462	462
query6	272	174	172	172
query7	4643	317	312	312
query8	275	230	223	223
query9	9583	2646	2659	2646
query10	483	263	269	263
query11	18174	15114	15126	15114
query12	159	104	99	99
query13	1651	426	426	426
query14	9779	7409	7422	7409
query15	257	168	187	168
query16	8193	474	458	458
query17	1674	578	562	562
query18	2154	310	319	310
query19	389	164	154	154
query20	117	104	114	104
query21	211	103	102	102
query22	4475	4138	4267	4138
query23	34587	33362	33433	33362
query24	11884	2836	2886	2836
query25	722	422	420	420
query26	1819	175	174	174
query27	2813	352	346	346
query28	7963	2459	2407	2407
query29	1039	452	440	440
query30	339	164	165	164
query31	1027	827	807	807
query32	95	61	59	59
query33	807	298	298	298
query34	927	501	518	501
query35	919	738	712	712
query36	1089	953	943	943
query37	153	74	69	69
query38	3910	3853	3952	3853
query39	1496	1427	1436	1427
query40	284	102	102	102
query41	55	52	52	52
query42	123	109	106	106
query43	547	496	494	494
query44	1297	828	821	821
query45	184	167	171	167
query46	1155	740	694	694
query47	1906	1824	1823	1823
query48	479	386	401	386
query49	1274	427	414	414
query50	832	418	422	418
query51	7305	7142	7224	7142
query52	111	92	95	92
query53	261	191	187	187
query54	1280	481	466	466
query55	81	81	83	81
query56	275	255	261	255
query57	1227	1114	1112	1112
query58	252	210	236	210
query59	3116	2868	3065	2868
query60	311	265	249	249
query61	128	105	129	105
query62	878	658	664	658
query63	233	190	190	190
query64	5261	683	697	683
query65	3313	3182	3176	3176
query66	1461	318	324	318
query67	16103	15466	15480	15466
query68	4884	584	595	584
query69	443	298	267	267
query70	1165	1142	1045	1045
query71	341	260	259	259
query72	6376	4018	3734	3734
query73	755	346	361	346
query74	10285	8907	8989	8907
query75	3359	2640	2674	2640
query76	2903	1097	1012	1012
query77	388	284	270	270
query78	10483	9617	9547	9547
query79	1104	605	593	593
query80	779	441	442	441
query81	503	234	237	234
query82	904	86	82	82
query83	240	142	148	142
query84	235	79	77	77
query85	1114	323	289	289
query86	315	304	293	293
query87	4402	4341	4303	4303
query88	3575	2413	2383	2383
query89	391	299	296	296
query90	2093	192	192	192
query91	185	147	149	147
query92	59	50	52	50
query93	1052	569	561	561
query94	819	277	308	277
query95	366	261	264	261
query96	605	280	280	280
query97	3291	3147	3152	3147
query98	213	202	190	190
query99	1506	1296	1305	1296
Total cold run time: 301430 ms
Total hot run time: 190694 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.13 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1d0a6416bfd1baeeec2a78325ccf215a77df4476, data reload: false

query1	0.03	0.02	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.10
query5	0.53	0.49	0.50
query6	1.13	0.72	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.52	0.50
query10	0.55	0.56	0.54
query11	0.14	0.10	0.10
query12	0.14	0.12	0.11
query13	0.62	0.60	0.60
query14	2.74	2.73	2.78
query15	0.89	0.82	0.82
query16	0.38	0.38	0.37
query17	1.06	1.06	1.02
query18	0.25	0.23	0.23
query19	1.90	1.86	1.92
query20	0.01	0.01	0.02
query21	15.36	0.59	0.57
query22	2.81	2.67	1.94
query23	17.02	0.87	0.88
query24	3.14	0.88	1.35
query25	0.35	0.08	0.09
query26	0.32	0.14	0.13
query27	0.04	0.05	0.04
query28	10.25	0.49	0.50
query29	12.62	3.18	3.18
query30	0.24	0.06	0.06
query31	2.86	0.39	0.37
query32	3.27	0.45	0.45
query33	2.97	2.98	3.05
query34	17.02	4.46	4.49
query35	4.54	4.50	4.51
query36	0.67	0.48	0.47
query37	0.10	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.87 s
Total hot run time: 32.13 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.90% (10166/26134)
Line Coverage 30.32% (86649/285826)
Region Coverage 29.36% (44502/151579)
Branch Coverage 25.87% (22631/87472)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 367d4e4 into apache:branch-3.0 Apr 1, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants