Skip to content

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Nov 17, 2020

Proposed changes

Disable v1 storage format when creating a new table in version 0.14, as we discussed in doris-dev and Issue #4835, I will forbidden the creation of segment v1 table

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@EmmyMiao87 EmmyMiao87 added area/config Issues or PRs related to configuration kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API area/storage Issues or PRs related to storage engine labels Nov 17, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Nov 19, 2020
@kangkaisen kangkaisen merged commit f445ed5 into apache:master Nov 20, 2020
@yangzhg yangzhg deleted the disable_create_segment_v1 branch November 20, 2020 02:45
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/config Issues or PRs related to configuration area/storage Issues or PRs related to storage engine kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Proposal] Disable v1 storage format when creating a new table in version 0.14

4 participants