【Optimize】optimize host selection strategy #4914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 13, 2020 22:09
morningman
reviewed
Nov 21, 2020
| Reference<Long> backendIdRef = new Reference<Long>(); | ||
| TNetworkAddress execHostPort = SimpleScheduler.getHost(minLocation.backend_id, | ||
| scanRangeLocations.getLocations(), this.idToBackend, backendIdRef); | ||
| if (execHostPort.hostname != minLocation.server.hostname || |
Contributor
There was a problem hiding this comment.
!execHostPort.hostname.equals(minLocation.server.hostname)
Contributor
Author
There was a problem hiding this comment.
Thanks for your review. I have modified it.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Nov 28, 2020
Introduced by apache#4914 apache#4912
caiconghui
pushed a commit
that referenced
this pull request
Nov 28, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When a tablet selects which replica's host to execute scan operation, it takes
round-robinstrategy to load balance.minAssignedBytesis the current load of one host. If a backend is not alive momently, it will randomly take one of other replicas as the choice, but the unalive backend'sminAssignedBytesnot be descreased and the new choice'sminAssignedBytesalso not be increased. That will make the real load of the backends not corret.Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...