Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #49009

### What problem does this PR solve?

1. fix wrong delete bitmap logs in
#41636 and
#48930
2. add count and cardinality log when calculating between segments
@github-actions github-actions bot requested a review from dataroaring as a code owner March 17, 2025 07:58
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 17, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40297 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 58ba909cd836a73ce31006652ca2edbb19267199, data reload: false

------ Round 1 ----------------------------------
q1	17570	6785	6661	6661
q2	2055	182	192	182
q3	10546	1102	1173	1102
q4	10551	717	746	717
q5	7774	2937	2880	2880
q6	220	139	128	128
q7	997	608	602	602
q8	9348	1949	2047	1949
q9	6745	6462	6416	6416
q10	7036	2255	2312	2255
q11	486	260	260	260
q12	405	212	208	208
q13	17777	3007	3011	3007
q14	239	211	205	205
q15	506	473	465	465
q16	681	607	585	585
q17	988	607	551	551
q18	7295	6728	6729	6728
q19	1396	1121	1066	1066
q20	484	204	194	194
q21	4077	3165	3192	3165
q22	1084	987	971	971
Total cold run time: 108260 ms
Total hot run time: 40297 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6642	6624	6591	6591
q2	336	227	227	227
q3	2932	2764	2958	2764
q4	2056	1843	1768	1768
q5	5859	5744	5766	5744
q6	213	126	126	126
q7	2220	1832	1806	1806
q8	3715	3586	3577	3577
q9	8745	8939	8924	8924
q10	3571	3538	3525	3525
q11	590	474	495	474
q12	794	634	636	634
q13	9021	3277	3144	3144
q14	310	279	260	260
q15	533	457	477	457
q16	684	656	651	651
q17	1900	1648	1619	1619
q18	8187	7970	7667	7667
q19	1701	1679	1611	1611
q20	2076	1890	1840	1840
q21	5617	5212	5492	5212
q22	1131	1045	1022	1022
Total cold run time: 68833 ms
Total hot run time: 59643 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196865 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 58ba909cd836a73ce31006652ca2edbb19267199, data reload: false

query1	1306	957	929	929
query2	6249	1964	1983	1964
query3	10794	4522	4311	4311
query4	65557	29033	23198	23198
query5	5033	459	446	446
query6	426	188	183	183
query7	5662	316	313	313
query8	312	232	219	219
query9	9294	2598	2595	2595
query10	475	279	256	256
query11	17703	14919	15740	14919
query12	147	105	103	103
query13	1533	457	439	439
query14	10462	7397	7373	7373
query15	204	173	175	173
query16	7199	511	483	483
query17	1046	571	589	571
query18	1981	310	301	301
query19	218	162	154	154
query20	115	111	105	105
query21	208	101	103	101
query22	4982	4417	4512	4417
query23	34535	34228	34217	34217
query24	6122	2964	2935	2935
query25	554	431	442	431
query26	662	172	168	168
query27	1780	365	364	364
query28	4339	2518	2457	2457
query29	710	468	463	463
query30	239	162	172	162
query31	995	828	829	828
query32	68	59	58	58
query33	455	311	327	311
query34	905	530	533	530
query35	850	742	730	730
query36	1100	970	946	946
query37	114	74	71	71
query38	4171	4055	4100	4055
query39	1508	1465	1495	1465
query40	204	99	93	93
query41	48	45	49	45
query42	111	102	99	99
query43	519	477	471	471
query44	1171	829	811	811
query45	187	169	169	169
query46	1171	732	717	717
query47	2056	1962	1979	1962
query48	484	380	375	375
query49	739	407	410	407
query50	820	425	429	425
query51	7252	6990	7149	6990
query52	99	85	85	85
query53	254	183	181	181
query54	540	440	454	440
query55	78	78	78	78
query56	257	242	235	235
query57	1243	1151	1126	1126
query58	205	208	195	195
query59	3073	3035	3140	3035
query60	281	281	249	249
query61	116	122	102	102
query62	780	658	667	658
query63	213	186	191	186
query64	1370	678	659	659
query65	3214	3170	3193	3170
query66	709	300	284	284
query67	16015	15575	15870	15575
query68	3556	598	600	598
query69	425	272	259	259
query70	1165	1135	1120	1120
query71	361	254	261	254
query72	6475	4064	4057	4057
query73	745	346	356	346
query74	10378	8755	9004	8755
query75	3342	2630	2653	2630
query76	1991	1083	1027	1027
query77	488	264	287	264
query78	10393	9591	9639	9591
query79	1476	602	607	602
query80	868	434	421	421
query81	504	241	238	238
query82	823	87	89	87
query83	163	155	139	139
query84	282	82	82	82
query85	821	312	325	312
query86	338	257	305	257
query87	4301	4228	4290	4228
query88	3804	2384	2362	2362
query89	418	290	287	287
query90	2039	178	184	178
query91	180	151	146	146
query92	64	47	48	47
query93	1632	559	563	559
query94	795	292	288	288
query95	359	253	253	253
query96	608	281	279	279
query97	3272	3198	3163	3163
query98	213	197	200	197
query99	1522	1273	1406	1273
Total cold run time: 317023 ms
Total hot run time: 196865 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.92 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 58ba909cd836a73ce31006652ca2edbb19267199, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.10
query5	0.53	0.53	0.52
query6	1.14	0.75	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.52	0.51
query10	0.54	0.55	0.56
query11	0.14	0.10	0.11
query12	0.13	0.11	0.11
query13	0.62	0.60	0.60
query14	2.73	2.88	2.86
query15	0.90	0.82	0.82
query16	0.39	0.37	0.38
query17	1.04	0.99	1.05
query18	0.25	0.22	0.21
query19	1.92	1.74	1.98
query20	0.02	0.01	0.00
query21	15.38	0.60	0.59
query22	2.56	2.51	1.93
query23	16.98	1.05	0.78
query24	3.10	1.15	0.66
query25	0.26	0.24	0.09
query26	0.46	0.14	0.14
query27	0.05	0.04	0.03
query28	10.61	0.48	0.47
query29	12.57	3.23	3.25
query30	0.25	0.06	0.06
query31	2.86	0.40	0.39
query32	3.25	0.46	0.46
query33	2.97	2.99	3.01
query34	17.05	4.48	4.45
query35	4.53	4.49	4.50
query36	0.67	0.49	0.49
query37	0.09	0.07	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.95 s
Total hot run time: 31.92 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 33.33% (2/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.88% (10168/26154)
Line Coverage 30.31% (86705/286089)
Region Coverage 29.35% (44540/151737)
Branch Coverage 25.88% (22658/87548)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit d0bc64e into branch-3.0 Mar 19, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49009-branch-3.0 branch March 19, 2025 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants