Skip to content

[fix](nereids) fix to_monday('1970-01-04 23:59:59') #49153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
starocean999 merged 1 commit into from
Mar 18, 2025
Merged

[fix](nereids) fix to_monday('1970-01-04 23:59:59') #49153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...che/doris/nereids/trees/expressions/functions/executable/DateTimeExtractAndTransform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@ public static Expression toMonday(DateTimeV2Literal date) {
}

private static LocalDateTime toMonday(LocalDateTime dateTime) {
LocalDateTime specialUpperBound = LocalDateTime.of(1970, 1, 4, 0, 0, 0);
LocalDateTime specialUpperBound = LocalDateTime.of(1970, 1, 4, 23, 59, 59, 999_999_999);
LocalDateTime specialLowerBound = LocalDateTime.of(1970, 1, 1, 0, 0, 0);
if (dateTime.isAfter(specialUpperBound) || dateTime.isBefore(specialLowerBound)) {
return dateTime.plusDays(-dateTime.getDayOfWeek().getValue() + 1);
Expand Down
29 changes: 28 additions & 1 deletion regression-test/suites/nereids_syntax_p0/test_cast_datetime.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,34 @@ suite("test_cast_datetime") {
result([[Date.valueOf('1970-01-01')]])
}

test {
sql "select to_monday('1969-12-31')"
result([[Date.valueOf('1969-12-29')]])
}

test {
sql "select to_monday('1969-12-31 23:59:59.999999')"
result([[Date.valueOf('1969-12-29')]])
}

// to_monday(1970-01-01 ~ 170-01-04) will return 1970-01-01
for (def s : ['1970-01-01', '1970-01-01 00:00:00.000001', '1970-01-02 12:00:00', '1970-01-01', '1970-01-04 23:59:59.999999']) {
test {
sql "select to_monday('${s}')"
result([[Date.valueOf('1970-01-01')]])
}
}

test {
sql "select to_monday('1970-01-05')"
result([[Date.valueOf('1970-01-05')]])
}

test {
sql "select to_monday('1970-01-05 00:00:00.000001')"
result([[Date.valueOf('1970-01-05')]])
}

test {
sql "select cast('123.123' as datetime)"
result([[LocalDateTime.parse('2012-03-12T03:00:00')]])
Expand Down Expand Up @@ -544,6 +572,5 @@ suite("test_cast_datetime") {
sql "select date_add('2023-11-05 01:30:00 America/New_York', INTERVAL 1 DAY)"
result([[LocalDateTime.parse('2023-11-06T01:30:00')]])
}

}
}
Loading