Skip to content

[opt](filecache) Do not remove parent directory when clear file cache #49199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 1 commit into from
Mar 22, 2025
Merged

[opt](filecache) Do not remove parent directory when clear file cache #49199

gavinchou merged 1 commit into from
Mar 22, 2025

Conversation

@gavinchou
Copy link
Contributor

@gavinchou gavinchou commented Mar 18, 2025 •
edited
Loading

What problem does this PR solve?

Release note

clear_file cache may not work in k8s environment, because it tries to delete the pvc path

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@gavinchou gavinchou requested a review from dataroaring as a code owner March 18, 2025 07:22
@Thearas
Copy link
Contributor

Thearas commented Mar 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

freemandealer
freemandealer suggested changes Mar 18, 2025
View reviewed changes
freemandealer
freemandealer approved these changes Mar 18, 2025
View reviewed changes
Copy link
Contributor

@freemandealer freemandealer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2025

PR approved by anyone and no changes requested.

@gavinchou
Copy link
Contributor Author

gavinchou commented Mar 18, 2025

run buildall

@gavinchou gavinchou added the p0_c label Mar 18, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 18, 2025

BE UT Coverage Report

Increment line coverage 67.86% (19/28) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 48.89% (13092/26780)
Line Coverage 38.44% (112860/293574)
Region Coverage 37.26% (57410/154064)
Branch Coverage 32.34% (28845/89198)

Hastyshell
Hastyshell approved these changes Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@Hastyshell Hastyshell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dataroaring
dataroaring approved these changes Mar 22, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2025

PR approved by at least one committer and no changes requested.

@gavinchou gavinchou merged commit cd0e5a7 into apache:master Mar 22, 2025
35 of 39 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 22, 2025
@gavinchou
[opt](filecache) Do not remove parent directory when clear file cache (…
0b08cbe 
…#49199)

clear_file cache may not work in k8s environment, because it tries to
delete the pvc path
@github-actions github-actions bot mentioned this pull request Mar 22, 2025
Merged
dataroaring pushed a commit that referenced this pull request Mar 25, 2025
@github-actions @gavinchou
branch-3.0: [opt](filecache) Do not remove parent directory when clea…
099722d 
…r file cache #49199 (#49360)

Cherry-picked from #49199

Co-authored-by: Gavin Chou <gavin@selectdb.com>
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@gavinchou @koarz
[opt](filecache) Do not remove parent directory when clear file cache (…
9e86f37 
…apache#49199)

clear_file cache may not work in k8s environment, because it tries to
delete the pvc path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

+2 more reviewers

@freemandealer freemandealer freemandealer approved these changes

@Hastyshell Hastyshell Hastyshell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.5-merged p0_c reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gavinchou @Thearas @hello-stephen @freemandealer @Hastyshell @dataroaring