Skip to content

Conversation

@ccoffline
Copy link
Contributor

Proposed changes

According to @morningman in #4836

We should check if inPredicate.getChild(0) is not a slotRef, do not create partition filter for it.
So it won't goes to the compareLiteral() logic.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

@ccoffline ccoffline changed the title fix partition prune (#4833) [Bug] Fix partition prune (#4833) Nov 18, 2020
@ccoffline
Copy link
Contributor Author

I still don't understand the concept of SlotRef=.=

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

I still don't understand the concept of SlotRef=.=

SlotRef sometimes means a "Column"

@morningman morningman added approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug. labels Nov 21, 2020
@morningman morningman merged commit c28769c into apache:master Nov 22, 2020
@ccoffline ccoffline deleted the fix-partition-prune branch November 23, 2020 02:54
@ccoffline
Copy link
Contributor Author

ccoffline commented Nov 23, 2020

SlotRef sometimes means a "Column"

thx~

@yangzhg yangzhg mentioned this pull request Feb 9, 2021
levy5307 pushed a commit to levy5307/incubator-doris that referenced this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants