Skip to content

[fix](webui) add connection context to avoid NPE #49213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Mar 19, 2025
Merged

[fix](webui) add connection context to avoid NPE #49213

morningman merged 1 commit into from
Mar 19, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Mar 18, 2025 •
edited
Loading

What problem does this PR solve?

Problem Summary:

When execute statement using Playgroup in FE webui, the NPE may thrown.
This is because we didn't set connection context when executing sql in StatementSubmmitter.
This PR fix it

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2025

PR approved by anyone and no changes requested.

@morningman
Copy link
Contributor Author

morningman commented Mar 18, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Mar 18, 2025

TPC-H: Total hot run time: 32404 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3b95f3b6d01185d9b3cefdbcf0d05db3d493f68e, data reload: false

------ Round 1 ----------------------------------
q1	24180	5076	5068	5068
q2	2049	360	214	214
q3	10282	1218	679	679
q4	10216	998	532	532
q5	7525	2367	2342	2342
q6	184	164	134	134
q7	917	729	635	635
q8	9344	1227	1096	1096
q9	5068	4526	4686	4526
q10	6806	2310	1894	1894
q11	487	269	255	255
q12	357	362	220	220
q13	17772	3679	3132	3132
q14	237	230	224	224
q15	527	482	471	471
q16	625	623	594	594
q17	580	850	351	351
q18	6814	6493	6394	6394
q19	1400	968	551	551
q20	313	321	202	202
q21	2775	2251	1929	1929
q22	1040	1018	961	961
Total cold run time: 109498 ms
Total hot run time: 32404 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5208	5145	5173	5145
q2	243	357	229	229
q3	2139	2619	2333	2333
q4	1406	1792	1381	1381
q5	4232	4098	4377	4098
q6	224	167	130	130
q7	1964	1890	1775	1775
q8	2614	2684	2580	2580
q9	7130	7118	7131	7118
q10	2996	3232	2645	2645
q11	558	507	516	507
q12	703	746	593	593
q13	3603	3912	3304	3304
q14	276	302	274	274
q15	537	491	471	471
q16	642	669	637	637
q17	1137	1577	1419	1419
q18	7728	7549	7555	7549
q19	862	809	860	809
q20	1963	2027	1877	1877
q21	5381	4668	4726	4668
q22	1088	1037	1083	1037
Total cold run time: 52634 ms
Total hot run time: 50579 ms

@doris-robot
Copy link

doris-robot commented Mar 18, 2025

TPC-DS: Total hot run time: 194110 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3b95f3b6d01185d9b3cefdbcf0d05db3d493f68e, data reload: false

query1	1408	1086	1061	1061
query2	6108	1897	1873	1873
query3	11011	4589	4679	4589
query4	54544	25432	23411	23411
query5	5059	656	494	494
query6	345	200	192	192
query7	4871	511	304	304
query8	315	255	248	248
query9	5285	2614	2602	2602
query10	419	323	257	257
query11	15367	15192	15251	15192
query12	165	114	106	106
query13	1022	504	409	409
query14	10269	7097	6908	6908
query15	224	214	196	196
query16	7138	689	492	492
query17	1105	746	591	591
query18	1543	427	334	334
query19	200	208	172	172
query20	127	118	130	118
query21	209	131	103	103
query22	4542	4612	4419	4419
query23	33953	33431	33515	33431
query24	5781	2508	2505	2505
query25	464	458	401	401
query26	722	276	155	155
query27	1952	502	338	338
query28	2803	2459	2476	2459
query29	634	587	429	429
query30	275	226	189	189
query31	875	871	780	780
query32	73	66	64	64
query33	506	377	324	324
query34	796	846	513	513
query35	818	844	776	776
query36	969	994	910	910
query37	126	104	77	77
query38	4247	4219	4214	4214
query39	1491	1451	1475	1451
query40	210	117	106	106
query41	54	50	51	50
query42	125	107	103	103
query43	509	504	499	499
query44	1419	808	821	808
query45	187	182	166	166
query46	882	1040	675	675
query47	1828	1846	1765	1765
query48	392	437	308	308
query49	692	521	425	425
query50	740	750	444	444
query51	4357	4328	4306	4306
query52	109	103	99	99
query53	246	271	200	200
query54	504	514	426	426
query55	86	85	82	82
query56	286	280	263	263
query57	1176	1186	1125	1125
query58	246	242	234	234
query59	2686	2783	2701	2701
query60	283	285	290	285
query61	121	119	122	119
query62	756	744	701	701
query63	235	196	192	192
query64	2157	1028	742	742
query65	4568	4455	4444	4444
query66	767	419	296	296
query67	15891	15696	15377	15377
query68	7127	837	506	506
query69	524	306	267	267
query70	1213	1137	1105	1105
query71	506	301	267	267
query72	5512	3686	3811	3686
query73	1518	739	348	348
query74	8963	9096	9021	9021
query75	4002	3155	2669	2669
query76	4275	1187	771	771
query77	778	377	293	293
query78	10158	10003	9301	9301
query79	4690	826	576	576
query80	717	533	434	434
query81	498	255	219	219
query82	752	126	102	102
query83	224	173	147	147
query84	281	97	77	77
query85	790	352	308	308
query86	361	325	283	283
query87	4498	4606	4517	4517
query88	3425	2316	2287	2287
query89	453	319	284	284
query90	1945	216	217	216
query91	142	138	110	110
query92	77	57	59	57
query93	2337	1039	575	575
query94	672	415	299	299
query95	347	265	264	264
query96	494	561	279	279
query97	3348	3441	3308	3308
query98	226	197	199	197
query99	1426	1404	1309	1309
Total cold run time: 301552 ms
Total hot run time: 194110 ms

@doris-robot
Copy link

doris-robot commented Mar 18, 2025

ClickBench: Total hot run time: 30.93 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3b95f3b6d01185d9b3cefdbcf0d05db3d493f68e, data reload: false

query1	0.04	0.03	0.03
query2	0.13	0.10	0.11
query3	0.25	0.20	0.19
query4	1.60	0.19	0.20
query5	0.58	0.60	0.58
query6	1.21	0.72	0.71
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.57	0.53	0.53
query10	0.59	0.59	0.57
query11	0.15	0.11	0.11
query12	0.15	0.11	0.11
query13	0.61	0.60	0.62
query14	2.66	2.69	2.80
query15	0.92	0.84	0.84
query16	0.38	0.38	0.39
query17	1.04	1.04	1.03
query18	0.21	0.19	0.20
query19	1.88	1.97	1.81
query20	0.02	0.01	0.01
query21	15.36	0.87	0.54
query22	0.75	1.14	0.59
query23	15.03	1.40	0.58
query24	7.62	1.17	0.74
query25	0.57	0.28	0.14
query26	0.59	0.16	0.14
query27	0.06	0.05	0.04
query28	9.87	0.84	0.42
query29	12.53	3.97	3.36
query30	0.25	0.09	0.06
query31	2.83	0.60	0.38
query32	3.23	0.55	0.47
query33	2.96	3.01	3.01
query34	15.91	5.12	4.49
query35	4.51	4.52	4.47
query36	0.67	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.02	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.27 s
Total hot run time: 30.93 s

@morningman morningman merged commit d482595 into apache:master Mar 19, 2025
30 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 19, 2025
@morningman
[fix](webui) add connection context to avoid NPE (#49213)
ebf4222 
### What problem does this PR solve?

Problem Summary:

When execute statement using Playgroup in FE webui, the NPE may thrown.
This is because we didn't set connection context when executing sql in
StatementSubmitter.
This PR fix it
@github-actions github-actions bot mentioned this pull request Mar 19, 2025
Merged
dataroaring pushed a commit that referenced this pull request Mar 20, 2025
@github-actions @morningman
branch-3.0: [fix](webui) add connection context to avoid NPE #49213 (#…
fe66d51 
…49228)

Cherry-picked from #49213

Co-authored-by: Mingyu Chen (Rayner) <morningman@163.com>
morningman added a commit to morningman/doris that referenced this pull request Mar 21, 2025
@morningman
[fix](webui) add connection context to avoid NPE (apache#49213)
90f3e63 
Problem Summary:

When execute statement using Playgroup in FE webui, the NPE may thrown.
This is because we didn't set connection context when executing sql in
StatementSubmitter.
This PR fix it
@morningman morningman mentioned this pull request Mar 21, 2025
Merged
yiguolei pushed a commit that referenced this pull request Mar 22, 2025
@morningman
[fix](webui) add connection context to avoid NPE (#49213) (#49353)
c3fad29 
bp #49213
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@morningman
[fix](webui) add connection context to avoid NPE (apache#49213)
f09b4e8 
### What problem does this PR solve?

Problem Summary:

When execute statement using Playgroup in FE webui, the NPE may thrown.
This is because we didn't set connection context when executing sql in
StatementSubmitter.
This PR fix it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@wuwenchi wuwenchi wuwenchi approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.9-merged dev/3.0.5-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@morningman @hello-stephen @doris-robot @CalvinKirs @wuwenchi @yiguolei @dataroaring