[fix](auth)Delete from should not check select_priv #49239

zddr · 2025-03-19T04:25:24Z

What problem does this PR solve?

Delete from should not check select_priv
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
Delete from should not check select_priv

Release note

Delete from should not check select_priv

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-03-19T04:25:29Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

zddr · 2025-03-19T04:25:41Z

run buildall

doris-robot · 2025-03-19T04:59:50Z

TPC-H: Total hot run time: 32394 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c0e52cfece2825ec9a0e698c74ba1972587eff97, data reload: false

------ Round 1 ----------------------------------
q1	23942	5115	5026	5026
q2	2049	296	181	181
q3	10381	1258	699	699
q4	10220	1024	534	534
q5	7536	2374	2362	2362
q6	189	160	133	133
q7	910	757	612	612
q8	9296	1236	1153	1153
q9	4985	4781	4826	4781
q10	6827	2322	1885	1885
q11	480	273	250	250
q12	352	369	223	223
q13	17782	3656	3075	3075
q14	233	229	205	205
q15	532	484	475	475
q16	626	605	572	572
q17	604	863	358	358
q18	6737	6397	6205	6205
q19	1216	956	560	560
q20	306	323	196	196
q21	2951	2230	1955	1955
q22	1038	1021	954	954
Total cold run time: 109192 ms
Total hot run time: 32394 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5292	5189	5171	5171
q2	237	326	235	235
q3	2167	2671	2284	2284
q4	1385	1807	1388	1388
q5	4217	4135	4438	4135
q6	225	173	136	136
q7	2008	1973	1821	1821
q8	2720	2720	2619	2619
q9	7333	7390	7326	7326
q10	3016	3183	2697	2697
q11	603	518	485	485
q12	664	783	636	636
q13	3433	3854	3304	3304
q14	278	285	261	261
q15	519	499	483	483
q16	647	676	625	625
q17	1127	1583	1360	1360
q18	7770	7584	7519	7519
q19	864	867	839	839
q20	1969	2036	1866	1866
q21	5338	4845	4846	4845
q22	1114	1031	1008	1008
Total cold run time: 52926 ms
Total hot run time: 51043 ms

doris-robot · 2025-03-19T05:12:05Z

TPC-DS: Total hot run time: 192352 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c0e52cfece2825ec9a0e698c74ba1972587eff97, data reload: false

query1	1404	1077	1066	1066
query2	6029	1901	1946	1901
query3	11001	4526	4293	4293
query4	54795	24717	23513	23513
query5	5135	651	474	474
query6	338	188	175	175
query7	4892	521	287	287
query8	292	251	228	228
query9	5600	2629	2622	2622
query10	426	318	258	258
query11	15229	15355	15069	15069
query12	167	109	105	105
query13	1049	514	395	395
query14	10679	6878	6426	6426
query15	207	203	185	185
query16	7138	637	494	494
query17	1096	739	574	574
query18	1533	416	332	332
query19	198	187	173	173
query20	133	139	126	126
query21	224	129	112	112
query22	4392	4530	4332	4332
query23	33973	33369	33335	33335
query24	6004	2442	2449	2442
query25	449	472	412	412
query26	733	285	154	154
query27	1864	493	333	333
query28	3108	2440	2454	2440
query29	603	569	461	461
query30	272	224	184	184
query31	888	881	799	799
query32	76	64	64	64
query33	459	388	318	318
query34	798	871	532	532
query35	861	851	757	757
query36	941	1030	968	968
query37	125	108	77	77
query38	4256	4278	4134	4134
query39	1495	1428	1420	1420
query40	209	117	105	105
query41	52	50	51	50
query42	122	116	108	108
query43	510	521	485	485
query44	1370	813	821	813
query45	189	178	173	173
query46	865	1038	681	681
query47	1849	1891	1808	1808
query48	389	415	305	305
query49	715	546	449	449
query50	716	778	453	453
query51	4285	4326	4292	4292
query52	109	100	101	100
query53	254	265	190	190
query54	509	510	427	427
query55	87	82	84	82
query56	284	263	274	263
query57	1174	1184	1132	1132
query58	285	249	239	239
query59	2979	2833	2631	2631
query60	297	281	270	270
query61	122	128	117	117
query62	736	740	678	678
query63	238	198	200	198
query64	1865	1020	714	714
query65	4562	4521	4477	4477
query66	749	402	287	287
query67	15814	15491	15323	15323
query68	6752	837	543	543
query69	530	313	262	262
query70	1214	1151	1126	1126
query71	527	327	261	261
query72	5509	3591	3718	3591
query73	1517	743	352	352
query74	9297	9055	8847	8847
query75	4104	3290	2716	2716
query76	4231	1198	771	771
query77	787	393	282	282
query78	10007	10006	9135	9135
query79	3539	832	566	566
query80	694	538	463	463
query81	490	267	219	219
query82	637	125	96	96
query83	212	177	156	156
query84	279	97	78	78
query85	766	418	298	298
query86	365	303	295	295
query87	4524	4479	4365	4365
query88	3724	2283	2271	2271
query89	410	314	284	284
query90	1918	217	234	217
query91	143	140	106	106
query92	75	59	57	57
query93	2222	1032	576	576
query94	656	421	305	305
query95	353	278	268	268
query96	495	566	277	277
query97	3327	3415	3307	3307
query98	236	205	199	199
query99	1421	1389	1243	1243
Total cold run time: 301158 ms
Total hot run time: 192352 ms

doris-robot · 2025-03-19T05:17:23Z

ClickBench: Total hot run time: 31.27 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c0e52cfece2825ec9a0e698c74ba1972587eff97, data reload: false

query1	0.04	0.03	0.03
query2	0.11	0.11	0.10
query3	0.24	0.20	0.19
query4	1.59	0.20	0.20
query5	0.61	0.58	0.60
query6	1.18	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.59	0.52	0.54
query10	0.57	0.59	0.57
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.61	0.61	0.59
query14	2.83	2.68	2.72
query15	0.90	0.87	0.85
query16	0.38	0.38	0.38
query17	1.07	1.02	1.02
query18	0.21	0.19	0.20
query19	1.93	1.94	1.84
query20	0.01	0.01	0.01
query21	15.39	0.90	0.55
query22	0.75	0.98	0.74
query23	15.00	1.41	0.62
query24	6.90	1.84	0.99
query25	0.53	0.36	0.10
query26	0.50	0.15	0.13
query27	0.05	0.04	0.04
query28	9.96	0.84	0.45
query29	12.55	3.94	3.27
query30	0.25	0.08	0.06
query31	2.82	0.58	0.38
query32	3.23	0.54	0.45
query33	2.98	2.99	3.00
query34	15.80	5.07	4.49
query35	4.51	4.56	4.48
query36	0.67	0.50	0.47
query37	0.08	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.13	0.13
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.02	0.02
Total cold run time: 105.63 s
Total hot run time: 31.27 s

zddr · 2025-03-19T09:48:21Z

run cloud_p0

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DeleteFromCommand.java

zddr · 2025-03-21T08:50:34Z

run buildall

doris-robot · 2025-03-21T09:27:21Z

TPC-H: Total hot run time: 33984 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9cf811b724d484e6a2bc5119b28cdd1698fabf63, data reload: false

------ Round 1 ----------------------------------
q1	23984	5061	5007	5007
q2	2045	285	167	167
q3	10420	1241	660	660
q4	10219	974	540	540
q5	7535	2480	2336	2336
q6	192	161	129	129
q7	903	746	597	597
q8	9289	1262	1118	1118
q9	6841	5070	5040	5040
q10	6818	2333	1925	1925
q11	492	274	267	267
q12	358	352	214	214
q13	17763	3637	3012	3012
q14	221	232	203	203
q15	534	478	480	478
q16	623	609	586	586
q17	570	842	352	352
q18	7530	7202	7182	7182
q19	1221	951	546	546
q20	320	322	190	190
q21	3939	2706	2440	2440
q22	1040	1014	995	995
Total cold run time: 112857 ms
Total hot run time: 33984 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5141	5110	5547	5110
q2	237	329	225	225
q3	2152	2646	2290	2290
q4	1426	1843	1379	1379
q5	4390	4504	4464	4464
q6	214	174	127	127
q7	2049	1942	1824	1824
q8	2664	2634	2549	2549
q9	7319	7291	7085	7085
q10	3003	3211	2768	2768
q11	574	520	490	490
q12	692	757	609	609
q13	3514	3892	3252	3252
q14	275	324	293	293
q15	529	484	494	484
q16	643	689	647	647
q17	1126	1594	1366	1366
q18	7712	7734	7615	7615
q19	827	895	943	895
q20	2014	2038	1805	1805
q21	5161	4976	4792	4792
q22	1119	1106	1030	1030
Total cold run time: 52781 ms
Total hot run time: 51099 ms

doris-robot · 2025-03-21T09:39:33Z

TPC-DS: Total hot run time: 193643 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9cf811b724d484e6a2bc5119b28cdd1698fabf63, data reload: false

query1	1428	1067	1053	1053
query2	6248	1912	1863	1863
query3	11181	4535	4518	4518
query4	54759	25523	22999	22999
query5	5015	568	489	489
query6	346	202	195	195
query7	4864	500	273	273
query8	311	267	243	243
query9	5596	2613	2631	2613
query10	417	315	257	257
query11	15154	15190	14901	14901
query12	152	109	105	105
query13	1051	519	396	396
query14	11340	7534	7116	7116
query15	221	206	171	171
query16	7155	676	490	490
query17	1073	722	564	564
query18	1720	402	314	314
query19	194	186	168	168
query20	128	119	120	119
query21	215	122	103	103
query22	4271	4500	4318	4318
query23	34047	33248	33447	33248
query24	5746	2446	2427	2427
query25	456	461	411	411
query26	691	265	141	141
query27	1769	517	326	326
query28	2799	2464	2439	2439
query29	575	580	465	465
query30	275	217	191	191
query31	863	909	780	780
query32	71	62	64	62
query33	474	399	319	319
query34	758	837	515	515
query35	803	862	760	760
query36	940	1002	900	900
query37	122	102	76	76
query38	4239	4325	4129	4129
query39	1512	1441	1423	1423
query40	206	119	108	108
query41	55	55	49	49
query42	124	107	102	102
query43	496	497	484	484
query44	1309	822	820	820
query45	186	175	170	170
query46	849	1062	659	659
query47	1841	1890	1787	1787
query48	392	424	308	308
query49	701	521	435	435
query50	699	749	432	432
query51	4320	4359	4290	4290
query52	108	106	96	96
query53	220	253	182	182
query54	491	491	420	420
query55	85	82	84	82
query56	273	264	277	264
query57	1215	1190	1122	1122
query58	246	243	245	243
query59	2724	2807	2596	2596
query60	282	281	278	278
query61	131	125	130	125
query62	723	751	695	695
query63	222	178	182	178
query64	1974	1066	696	696
query65	4541	4487	4535	4487
query66	718	388	287	287
query67	15723	15322	15110	15110
query68	5849	874	507	507
query69	531	318	276	276
query70	1210	1092	1115	1092
query71	443	284	271	271
query72	5927	5261	5301	5261
query73	1374	693	350	350
query74	9298	9063	8687	8687
query75	3266	3238	2725	2725
query76	3841	1187	743	743
query77	567	369	282	282
query78	10151	10308	9321	9321
query79	1433	933	565	565
query80	658	516	440	440
query81	489	251	231	231
query82	205	125	96	96
query83	174	167	155	155
query84	286	91	78	78
query85	762	348	354	348
query86	331	302	298	298
query87	4577	4424	4425	4424
query88	2879	2266	2246	2246
query89	392	309	281	281
query90	1695	210	218	210
query91	222	144	109	109
query92	62	59	52	52
query93	1269	1055	584	584
query94	644	420	294	294
query95	357	271	267	267
query96	499	561	277	277
query97	3343	3454	3290	3290
query98	218	212	202	202
query99	1313	1397	1296	1296
Total cold run time: 294098 ms
Total hot run time: 193643 ms

doris-robot · 2025-03-21T09:44:53Z

ClickBench: Total hot run time: 31.03 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9cf811b724d484e6a2bc5119b28cdd1698fabf63, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.10	0.10
query3	0.24	0.19	0.19
query4	1.60	0.19	0.19
query5	0.60	0.58	0.59
query6	1.19	0.71	0.73
query7	0.02	0.01	0.02
query8	0.04	0.03	0.04
query9	0.58	0.52	0.52
query10	0.60	0.59	0.58
query11	0.15	0.10	0.11
query12	0.15	0.12	0.11
query13	0.61	0.59	0.62
query14	2.81	2.81	2.68
query15	0.93	0.85	0.86
query16	0.37	0.38	0.38
query17	1.02	1.04	1.02
query18	0.20	0.20	0.19
query19	1.97	1.98	1.76
query20	0.01	0.01	0.02
query21	15.35	0.93	0.53
query22	0.75	1.34	0.77
query23	14.74	1.38	0.66
query24	7.01	2.48	0.55
query25	0.51	0.23	0.09
query26	0.57	0.17	0.13
query27	0.05	0.04	0.05
query28	9.52	0.84	0.44
query29	12.59	4.10	3.37
query30	0.25	0.09	0.07
query31	2.81	0.59	0.37
query32	3.23	0.54	0.47
query33	2.98	3.03	3.05
query34	15.87	5.11	4.50
query35	4.57	4.59	4.57
query36	0.67	0.50	0.50
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.18	0.14	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.23 s
Total hot run time: 31.03 s

github-actions · 2025-03-27T11:39:33Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-03-27T11:39:35Z

PR approved by anyone and no changes requested.

zfr9527

LGTM

### What problem does this PR solve? Problem Summary: Delete from should not check select_priv

#49620) Cherry-picked from #49239 Co-authored-by: zhangdong <zhangdong@selectdb.com>

pick: #49239

### What problem does this PR solve? Problem Summary: Delete from should not check select_priv

zddr added 2 commits March 19, 2025 10:51

1

d3686a2

1

c0e52cf

morrySnow reviewed Mar 20, 2025

View reviewed changes

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DeleteFromCommand.java Outdated Show resolved Hide resolved

fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DeleteFromCommand.java Outdated Show resolved Hide resolved

morrySnow added dev/2.1.x dev/3.0.x labels Mar 20, 2025

1

9cf811b

zddr requested a review from morrySnow March 21, 2025 08:50

morrySnow approved these changes Mar 27, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 27, 2025

github-actions bot added the reviewed label Mar 27, 2025

zfr9527 approved these changes Mar 27, 2025

View reviewed changes

morningman self-assigned this Mar 27, 2025

morningman merged commit d2a574a into apache:master Mar 28, 2025
25 of 26 checks passed

github-actions bot pushed a commit that referenced this pull request Mar 28, 2025

[fix](auth)Delete from should not check select_priv (#49239)

11209a5

### What problem does this PR solve? Problem Summary: Delete from should not check select_priv

github-actions bot mentioned this pull request Mar 28, 2025

branch-3.0: [fix](auth)Delete from should not check select_priv #49239 #49620

Merged

github-actions bot added the dev/2.1.x-conflict label Mar 28, 2025

dataroaring pushed a commit that referenced this pull request Mar 30, 2025

branch-3.0: [fix](auth)Delete from should not check select_priv #49239 (

d5544ca

#49620) Cherry-picked from #49239 Co-authored-by: zhangdong <zhangdong@selectdb.com>

dataroaring added the dev/3.0.5-merged label Mar 30, 2025

dataroaring removed the dev/3.0.x label Mar 30, 2025

zddr mentioned this pull request Apr 3, 2025

branch-2.1:[fix](auth)Delete from should not check select_priv #49794

Merged

yiguolei added dev/2.1.10-merged and removed dev/2.1.x dev/2.1.x-conflict labels Apr 4, 2025

yiguolei pushed a commit that referenced this pull request Apr 4, 2025

branch-2.1:[fix](auth)Delete from should not check select_priv (#49794)

3a282bd

pick: #49239

gavinchou mentioned this pull request Apr 23, 2025

Release Notes 3.0.5 #50333

Closed

koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025

[fix](auth)Delete from should not check select_priv (apache#49239)

980c16d

### What problem does this PR solve? Problem Summary: Delete from should not check select_priv

[fix](auth)Delete from should not check select_priv #49239

[fix](auth)Delete from should not check select_priv #49239

Uh oh!

Conversation

zddr commented Mar 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Mar 19, 2025

Uh oh!

zddr commented Mar 19, 2025

Uh oh!

doris-robot commented Mar 19, 2025

Uh oh!

doris-robot commented Mar 19, 2025

Uh oh!

doris-robot commented Mar 19, 2025

Uh oh!

zddr commented Mar 19, 2025

Uh oh!

Uh oh!

Uh oh!

zddr commented Mar 21, 2025

Uh oh!

doris-robot commented Mar 21, 2025

Uh oh!

doris-robot commented Mar 21, 2025

Uh oh!

doris-robot commented Mar 21, 2025

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

github-actions bot commented Mar 27, 2025

Uh oh!

zfr9527 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

zddr commented Mar 19, 2025 •

edited

Loading