Skip to content

Conversation

@id4alexsu
Copy link
Contributor

Proposed changes

This is a minor issue when we had FE start after a fresh installation, but it will occur an error about the log directory is missing due to log directory is not existed before some environment check message outputing to the log file. , the log directory creation code in bin/start_fe.sh is in the wrong place, only need to put the log directory creation code in the beginning.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kangkaisen kangkaisen added approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug. labels Nov 20, 2020
@morningman morningman merged commit 8e9bbfb into apache:master Nov 22, 2020
@id4alexsu id4alexsu deleted the fix-logs-dir-create-issue branch November 22, 2020 14:26
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. good first issue kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants