-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Enhancement] add information_schema backend_tablets table #49317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
7f50327 to
704705b
Compare
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 34242 ms |
TPC-DS: Total hot run time: 195457 ms |
ClickBench: Total hot run time: 31.73 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 34544 ms |
TPC-DS: Total hot run time: 186928 ms |
ClickBench: Total hot run time: 30.97 s |
4e02d5c to
58155f5
Compare
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 34890 ms |
TPC-DS: Total hot run time: 187158 ms |
ClickBench: Total hot run time: 30.94 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run cloud_p0 |
…ains meta about tablets
58155f5 to
72572b5
Compare
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 34706 ms |
TPC-DS: Total hot run time: 193650 ms |
ClickBench: Total hot run time: 32 s |
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 34269 ms |
TPC-DS: Total hot run time: 191780 ms |
ClickBench: Total hot run time: 31.56 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the Status SchemaTabletsScanner::_fill_block_impl(vectorized::Block* block){}, you can add a lambda function like:
auto fill_column = [&](int column_index, auto data_extractor) {
using ValueType = std::remove_reference_t<decltype(data_extractor(_tablets[0]))>;
std::vector<ValueType> srcs(fill_tablets_num);
for (size_t i = 0; i < fill_tablets_num; ++i) {
TabletSharedPtr tablet = _tablets[fill_idx_begin + i];
srcs[i] = data_extractor(tablet);
datas[i] = &srcs[i];
}
return fill_dest_column_for_range(block, column_index, datas);
};
Then you could call it to make the code more concise like:
RETURN_IF_ERROR(fill_column(0, [this](auto tablet) { return _backend_id; }));
RETURN_IF_ERROR(fill_column(1, [](auto tablet) { return tablet->tablet_meta()->table_id(); }));
...
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggest, thank you
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 34196 ms |
TPC-DS: Total hot run time: 193432 ms |
ClickBench: Total hot run time: 31.93 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
Please add a multiple BE query result in description, to prove it can fetch multipe BE result. |
### What problem does this PR solve? complete: #49317 Co-Author: DongLiang-0 Co-authored-by: DongLiang-0 <wudongliang@selectdb.com>
What problem does this PR solve?
Add
information_schema.backend_tabletstable to record the metadata information of the tablet.Issue Number: close #48892
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)