[Bug] Fix the bug of NULL do not show in CTE statement. #4932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmyMiao87
approved these changes
Nov 20, 2020
| columnList.add(new Column(colAlias, selectItemExpr.getType().getPrimitiveType())); | ||
| // TODO: inlineView threat all column is nullable to make sure query results are correct | ||
| // we should judge column whether is nullable by selectItemExpr in the future | ||
| columnList.add(new Column(colAlias, selectItemExpr.getType().getPrimitiveType(), true)); |
Contributor
There was a problem hiding this comment.
Unfortunately, we cannot directly obtain the information about whether slot desc is nullable or not from Expr.
Contributor
|
Please add more commit log |
Contributor
Author
done |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Column create in inlineView will set
allowNull = false, which will causeNULLdata in CTE be process will be ignore.So we should set column in inlineView allowNull to make sure correct of query.
issue:#4926
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.