-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](cloud-mow) Fix dup key problem due to calculating delete bitmaps for incremental rowsets based on wrong historical rowsets during SC #49350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34174 ms |
TPC-DS: Total hot run time: 193767 ms |
ClickBench: Total hot run time: 31.31 s |
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run p0 |
|
run cloud_p0 |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…s for incremental rowsets based on wrong historical rowsets during SC (#49350) ### What problem does this PR solve? When calculating delete bitmaps for incremental rowsets during schema change double write phase, `sync_rowsets` on tmp_tablet may override local converted historical rowsets with rowsets on new tablet. But these rowsets will be removed when commit sc job. This PR re-add converted rowsets after `sync_rowsets` to avoid the problem
…s for incremental rowsets based on wrong historical rowsets during SC (apache#49350) ### What problem does this PR solve? When calculating delete bitmaps for incremental rowsets during schema change double write phase, `sync_rowsets` on tmp_tablet may override local converted historical rowsets with rowsets on new tablet. But these rowsets will be removed when commit sc job. This PR re-add converted rowsets after `sync_rowsets` to avoid the problem
What problem does this PR solve?
When calculating delete bitmaps for incremental rowsets during schema change double write phase,
sync_rowsetson tmp_tablet may override local converted historical rowsets with rowsets on new tablet. But these rowsets will be removed when commit sc job.This PR re-add converted rowsets after
sync_rowsetsto avoid the problemRelease note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)