Skip to content

Conversation

@qzsee
Copy link
Contributor

@qzsee qzsee commented Mar 24, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #44365

Problem Summary:

select array_map(x-> array_max(array_map(y -> y+1, a2) + x), a1) from (select 1 d, [1,2,3] a1, [1,2,3] a2) a

it can be core

because currently lambda does not support multi-layer nesting

Repair first, support later

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@qzsee qzsee force-pushed the fix-lambda-expr branch from e45cf71 to 263b571 Compare March 24, 2025 03:15
@dqz123
Copy link

dqz123 commented Mar 24, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34313 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1b61d86b3ec104ce4381fd19be6496bd631b8bc3, data reload: false

------ Round 1 ----------------------------------
q1	24587	5109	5075	5075
q2	2047	318	179	179
q3	10590	1265	719	719
q4	10246	1047	540	540
q5	7852	2442	2348	2348
q6	188	163	132	132
q7	915	747	617	617
q8	9327	1334	1083	1083
q9	6867	5160	5094	5094
q10	6875	2315	1910	1910
q11	494	279	247	247
q12	340	348	212	212
q13	17779	3707	3073	3073
q14	223	229	206	206
q15	522	470	481	470
q16	645	631	588	588
q17	583	879	338	338
q18	7837	7187	7211	7187
q19	1666	961	593	593
q20	318	335	193	193
q21	4107	3606	2528	2528
q22	1072	1033	981	981
Total cold run time: 115080 ms
Total hot run time: 34313 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5233	5108	5222	5108
q2	238	326	220	220
q3	2155	2688	2361	2361
q4	1419	1798	1454	1454
q5	4532	4478	4417	4417
q6	218	173	126	126
q7	2003	1921	1761	1761
q8	2617	2490	2558	2490
q9	7221	7308	7214	7214
q10	2996	3178	2763	2763
q11	570	496	494	494
q12	690	786	622	622
q13	3464	3955	3198	3198
q14	275	289	267	267
q15	527	484	462	462
q16	638	694	643	643
q17	1165	1557	1353	1353
q18	7613	7558	7497	7497
q19	811	850	1023	850
q20	1935	2032	1874	1874
q21	5252	4819	4676	4676
q22	1097	1032	1008	1008
Total cold run time: 52669 ms
Total hot run time: 50858 ms

@doris-robot
Copy link

TPC-H: Total hot run time: 34044 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1b61d86b3ec104ce4381fd19be6496bd631b8bc3, data reload: false

------ Round 1 ----------------------------------
q1	24257	5063	5054	5054
q2	2049	312	195	195
q3	10357	1225	684	684
q4	10220	1013	548	548
q5	7533	2408	2266	2266
q6	190	163	134	134
q7	937	742	593	593
q8	9316	1295	1116	1116
q9	6859	5164	5165	5164
q10	6862	2301	1902	1902
q11	492	281	259	259
q12	354	365	216	216
q13	17763	3626	3092	3092
q14	223	228	213	213
q15	530	506	478	478
q16	617	638	587	587
q17	601	863	345	345
q18	7490	7244	6984	6984
q19	1394	975	558	558
q20	334	327	192	192
q21	3968	3407	2483	2483
q22	1060	1009	981	981
Total cold run time: 113406 ms
Total hot run time: 34044 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5199	5163	5225	5163
q2	249	325	236	236
q3	2138	2688	2290	2290
q4	1433	1808	1426	1426
q5	4430	4427	4409	4409
q6	216	168	138	138
q7	2031	1939	1777	1777
q8	2591	2592	2547	2547
q9	7219	7196	7038	7038
q10	3050	3204	2778	2778
q11	564	525	493	493
q12	710	761	629	629
q13	3533	3937	3308	3308
q14	281	308	289	289
q15	543	482	486	482
q16	655	680	652	652
q17	1151	1580	1387	1387
q18	8081	7936	7796	7796
q19	844	838	895	838
q20	1894	1937	1818	1818
q21	5499	4944	4824	4824
q22	1109	1055	998	998
Total cold run time: 53420 ms
Total hot run time: 51316 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194011 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1b61d86b3ec104ce4381fd19be6496bd631b8bc3, data reload: false

query1	1403	1044	1028	1028
query2	6307	1861	1883	1861
query3	11033	4562	4416	4416
query4	53101	25143	23003	23003
query5	4920	655	496	496
query6	342	199	205	199
query7	4869	499	274	274
query8	318	246	247	246
query9	5468	2590	2592	2590
query10	434	328	247	247
query11	15134	15060	14914	14914
query12	165	113	109	109
query13	1015	497	379	379
query14	11741	6967	7439	6967
query15	196	188	167	167
query16	7040	691	517	517
query17	1065	749	582	582
query18	1452	399	342	342
query19	198	189	171	171
query20	130	121	119	119
query21	208	124	105	105
query22	4768	4540	4504	4504
query23	33941	33377	33407	33377
query24	5751	2497	2466	2466
query25	454	471	405	405
query26	694	267	143	143
query27	1745	491	329	329
query28	2915	2448	2425	2425
query29	550	548	433	433
query30	275	232	198	198
query31	886	880	785	785
query32	71	62	64	62
query33	445	364	303	303
query34	769	882	510	510
query35	864	848	771	771
query36	1002	1006	918	918
query37	111	99	71	71
query38	4462	4284	4184	4184
query39	1491	1419	1457	1419
query40	202	117	104	104
query41	53	53	49	49
query42	123	111	102	102
query43	505	524	498	498
query44	1346	815	793	793
query45	182	175	167	167
query46	853	1109	645	645
query47	1858	1900	1813	1813
query48	405	432	313	313
query49	672	509	436	436
query50	696	757	429	429
query51	4276	4336	4229	4229
query52	106	105	98	98
query53	226	264	187	187
query54	484	494	427	427
query55	84	83	87	83
query56	299	258	270	258
query57	1177	1221	1118	1118
query58	264	266	252	252
query59	2563	2930	2657	2657
query60	297	283	285	283
query61	153	153	153	153
query62	768	752	687	687
query63	227	184	196	184
query64	1866	1024	687	687
query65	4557	4452	4376	4376
query66	702	393	288	288
query67	15815	15713	15372	15372
query68	7003	882	501	501
query69	534	299	270	270
query70	1229	1116	1166	1116
query71	506	290	255	255
query72	5530	5192	5120	5120
query73	1466	631	343	343
query74	9041	9120	8965	8965
query75	4280	3235	2798	2798
query76	4239	1199	739	739
query77	814	372	289	289
query78	10069	10050	9295	9295
query79	2879	826	564	564
query80	640	505	445	445
query81	485	255	216	216
query82	712	125	94	94
query83	209	171	154	154
query84	289	104	76	76
query85	761	341	387	341
query86	358	303	292	292
query87	4483	4516	4368	4368
query88	3753	2271	2277	2271
query89	436	309	282	282
query90	1843	221	213	213
query91	151	142	110	110
query92	68	60	55	55
query93	2163	1032	577	577
query94	665	415	307	307
query95	354	275	263	263
query96	491	566	278	278
query97	3380	3368	3223	3223
query98	280	199	200	199
query99	1442	1425	1269	1269
Total cold run time: 299045 ms
Total hot run time: 194011 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.47 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1b61d86b3ec104ce4381fd19be6496bd631b8bc3, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.11
query3	0.25	0.18	0.20
query4	1.61	0.20	0.20
query5	0.60	0.59	0.61
query6	1.19	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.57	0.54	0.52
query10	0.59	0.62	0.55
query11	0.15	0.10	0.11
query12	0.15	0.11	0.11
query13	0.62	0.60	0.62
query14	2.70	2.80	2.83
query15	0.95	0.85	0.86
query16	0.39	0.39	0.39
query17	1.05	1.05	1.06
query18	0.21	0.20	0.19
query19	1.93	1.96	1.77
query20	0.01	0.01	0.01
query21	15.36	0.86	0.54
query22	0.75	1.21	0.79
query23	14.80	1.39	0.60
query24	6.69	1.44	0.88
query25	0.47	0.33	0.06
query26	0.51	0.17	0.14
query27	0.06	0.05	0.05
query28	9.97	0.86	0.44
query29	12.55	3.96	3.38
query30	0.26	0.11	0.06
query31	2.83	0.59	0.40
query32	3.23	0.54	0.48
query33	2.99	3.01	3.08
query34	15.75	5.08	4.55
query35	4.59	4.50	4.48
query36	0.67	0.50	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.13	0.12
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 105.16 s
Total hot run time: 31.47 s

@dqz123
Copy link

dqz123 commented Mar 24, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34245 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 307f02dc8b91bbbb6532d7ff12ce6ad8dc0e0f40, data reload: false

------ Round 1 ----------------------------------
q1	26380	5236	5084	5084
q2	2076	289	158	158
q3	10405	1254	694	694
q4	10234	1016	532	532
q5	7536	2386	2355	2355
q6	199	169	135	135
q7	929	741	620	620
q8	9324	1239	1140	1140
q9	6880	5136	5121	5121
q10	6880	2323	1882	1882
q11	474	275	268	268
q12	357	364	220	220
q13	17787	3720	3059	3059
q14	236	230	216	216
q15	525	479	491	479
q16	616	627	599	599
q17	584	920	349	349
q18	7504	7363	7109	7109
q19	2010	971	564	564
q20	325	349	199	199
q21	4040	2824	2487	2487
q22	1081	993	975	975
Total cold run time: 116382 ms
Total hot run time: 34245 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5270	5160	5162	5160
q2	235	332	232	232
q3	2170	2631	2341	2341
q4	1431	1838	1455	1455
q5	4469	4491	4415	4415
q6	218	168	132	132
q7	2021	1946	1775	1775
q8	2638	2587	2578	2578
q9	7371	7105	7124	7105
q10	3025	3209	2761	2761
q11	581	507	500	500
q12	722	794	622	622
q13	3476	3941	3404	3404
q14	308	316	265	265
q15	524	465	482	465
q16	644	682	641	641
q17	1190	1624	1355	1355
q18	7851	7634	7532	7532
q19	827	823	855	823
q20	1925	1971	1828	1828
q21	5354	4987	4932	4932
q22	1098	1076	1051	1051
Total cold run time: 53348 ms
Total hot run time: 51372 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192928 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 307f02dc8b91bbbb6532d7ff12ce6ad8dc0e0f40, data reload: false

query1	1412	1067	1060	1060
query2	6076	1893	1872	1872
query3	11038	4126	4632	4126
query4	56736	25929	23539	23539
query5	5112	517	485	485
query6	346	208	184	184
query7	4954	483	270	270
query8	335	258	224	224
query9	6105	2588	2597	2588
query10	436	326	258	258
query11	15312	15105	14920	14920
query12	158	121	105	105
query13	1104	527	395	395
query14	10111	6428	6253	6253
query15	204	186	184	184
query16	7147	648	479	479
query17	1065	735	590	590
query18	1528	426	319	319
query19	206	211	174	174
query20	135	130	125	125
query21	226	124	102	102
query22	4586	4567	4362	4362
query23	33831	33261	33310	33261
query24	6869	2425	2440	2425
query25	456	464	384	384
query26	686	280	151	151
query27	2249	508	326	326
query28	3275	2464	2440	2440
query29	568	552	427	427
query30	283	222	191	191
query31	906	882	788	788
query32	68	66	60	60
query33	472	371	303	303
query34	751	830	499	499
query35	815	849	743	743
query36	949	1023	933	933
query37	124	101	78	78
query38	4249	4227	4146	4146
query39	1534	1435	1444	1435
query40	210	120	112	112
query41	54	51	50	50
query42	119	104	105	104
query43	502	525	476	476
query44	1334	818	831	818
query45	187	183	168	168
query46	852	1029	641	641
query47	1862	1880	1800	1800
query48	398	429	315	315
query49	686	508	427	427
query50	687	752	417	417
query51	4240	4347	4264	4264
query52	104	110	100	100
query53	224	265	190	190
query54	477	497	410	410
query55	87	84	86	84
query56	312	276	262	262
query57	1205	1219	1138	1138
query58	256	247	238	238
query59	2738	2834	2592	2592
query60	288	284	275	275
query61	135	132	175	132
query62	757	740	683	683
query63	221	178	187	178
query64	1551	1034	693	693
query65	4550	4434	4440	4434
query66	715	391	293	293
query67	15868	15581	15412	15412
query68	7870	823	514	514
query69	568	301	265	265
query70	1216	1130	1090	1090
query71	482	303	256	256
query72	5800	5155	5243	5155
query73	1396	661	343	343
query74	8994	9093	8715	8715
query75	3831	3238	2698	2698
query76	4330	1197	763	763
query77	609	375	282	282
query78	10083	10275	9271	9271
query79	2292	804	583	583
query80	698	530	449	449
query81	479	262	284	262
query82	467	127	99	99
query83	176	170	156	156
query84	289	99	73	73
query85	784	362	311	311
query86	408	301	289	289
query87	4421	4517	4315	4315
query88	3622	2253	2260	2253
query89	397	321	275	275
query90	1775	205	214	205
query91	146	138	111	111
query92	71	59	58	58
query93	2058	1057	582	582
query94	650	414	310	310
query95	346	278	265	265
query96	481	559	281	281
query97	3354	3382	3299	3299
query98	225	204	206	204
query99	1481	1396	1286	1286
Total cold run time: 302835 ms
Total hot run time: 192928 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.73 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 307f02dc8b91bbbb6532d7ff12ce6ad8dc0e0f40, data reload: false

query1	0.04	0.04	0.03
query2	0.11	0.10	0.11
query3	0.25	0.19	0.20
query4	1.59	0.18	0.19
query5	0.61	0.60	0.61
query6	1.17	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.50	0.51
query10	0.58	0.61	0.57
query11	0.16	0.10	0.11
query12	0.14	0.12	0.12
query13	0.64	0.61	0.61
query14	2.68	2.84	2.81
query15	0.93	0.87	0.86
query16	0.39	0.40	0.39
query17	1.04	1.01	1.02
query18	0.22	0.20	0.19
query19	1.90	2.02	1.82
query20	0.02	0.01	0.01
query21	15.35	0.92	0.54
query22	0.75	1.11	0.76
query23	14.93	1.41	0.64
query24	7.21	1.59	1.05
query25	0.53	0.26	0.08
query26	0.50	0.16	0.13
query27	0.05	0.05	0.05
query28	10.15	0.83	0.44
query29	12.55	4.10	3.38
query30	0.25	0.09	0.07
query31	2.85	0.62	0.39
query32	3.23	0.56	0.49
query33	3.11	3.05	3.11
query34	15.78	5.12	4.48
query35	4.53	4.54	4.50
query36	0.67	0.50	0.50
query37	0.08	0.07	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.02	0.03
query43	0.03	0.04	0.03
Total cold run time: 106.03 s
Total hot run time: 31.73 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/25) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 49.96% (13370/26763)
Line Coverage 39.41% (115680/293493)
Region Coverage 38.13% (58750/154085)
Branch Coverage 33.27% (29662/89146)

@github-actions
Copy link
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Sep 21, 2025
@github-actions github-actions bot closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants