[fix](function) wrong result of arrays_overlap #49403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
TPC-H: Total hot run time: 34233 ms |
TPC-DS: Total hot run time: 193754 ms |
ClickBench: Total hot run time: 30.73 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
reviewed
Mar 24, 2025
| 2019-01-01 26823b3995ee38bd145ddd910b2f6300 ["x"] | ||
| 2019-01-01 a648a447b8f71522f11632eba4b4adde ["p", "q", "r", "s", "t"] | ||
| 2019-01-01 a9fb5c985c90bf05f3bee5ca3ae95260 ["u", "v"] | ||
| 2019-01-01 ee27ee1da291e46403c408e220bed6e1 ["y"] |
Contributor
There was a problem hiding this comment.
我们改了arrays overlap，为啥会改array contains的case？
8 tasks
yiguolei
approved these changes
Mar 25, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
amorynan
reviewed
Mar 26, 2025
| const UInt8* dst_nullmap_data, UInt8* dst_data) const { | ||
| const ColumnArrayExecutionData& right_data, UInt8* dst_nullmap_data, | ||
| UInt8* dst_data) const { | ||
| using ExecutorImpl = OverlapSetImpl<T>; |
Contributor
There was a problem hiding this comment.
is this logic same with inverted index case ?
mrhhsg
added a commit
to mrhhsg/doris
that referenced
this pull request
Mar 31, 2025
If the two arrays have the same non-null elements, they are considered overlapping, and the result is 1. If the two arrays have no common non-null elements and either array contains a null element, the result is null. Otherwise, the result is 0. ``` select arrays_overlap([1, 2, 3], [1, null]); -- result should be 1 select arrays_overlap([2, 3], [1, null]); -- result should be null select arrays_overlap([2, 3], [1]); -- result should be 0 ```
16 tasks
mrhhsg
added a commit
to mrhhsg/doris
that referenced
this pull request
Mar 31, 2025
If the two arrays have the same non-null elements, they are considered overlapping, and the result is 1. If the two arrays have no common non-null elements and either array contains a null element, the result is null. Otherwise, the result is 0. ``` select arrays_overlap([1, 2, 3], [1, null]); -- result should be 1 select arrays_overlap([2, 3], [1, null]); -- result should be null select arrays_overlap([2, 3], [1]); -- result should be 0 ```
16 tasks
mrhhsg
added a commit
to mrhhsg/doris
that referenced
this pull request
Apr 1, 2025
If the two arrays have the same non-null elements, they are considered overlapping, and the result is 1. If the two arrays have no common non-null elements and either array contains a null element, the result is null. Otherwise, the result is 0. ``` select arrays_overlap([1, 2, 3], [1, null]); -- result should be 1 select arrays_overlap([2, 3], [1, null]); -- result should be null select arrays_overlap([2, 3], [1]); -- result should be 0 ```
mrhhsg
added a commit
to mrhhsg/doris
that referenced
this pull request
Apr 3, 2025
If the two arrays have the same non-null elements, they are considered overlapping, and the result is 1. If the two arrays have no common non-null elements and either array contains a null element, the result is null. Otherwise, the result is 0. ``` select arrays_overlap([1, 2, 3], [1, null]); -- result should be 1 select arrays_overlap([2, 3], [1, null]); -- result should be null select arrays_overlap([2, 3], [1]); -- result should be 0 ```
mrhhsg
added a commit
to mrhhsg/doris
that referenced
this pull request
Apr 3, 2025
If the two arrays have the same non-null elements, they are considered overlapping, and the result is 1. If the two arrays have no common non-null elements and either array contains a null element, the result is null. Otherwise, the result is 0. ``` select arrays_overlap([1, 2, 3], [1, null]); -- result should be 1 select arrays_overlap([2, 3], [1, null]); -- result should be null select arrays_overlap([2, 3], [1]); -- result should be 0 ```
mrhhsg
added a commit
to mrhhsg/doris
that referenced
this pull request
Apr 3, 2025
If the two arrays have the same non-null elements, they are considered overlapping, and the result is 1. If the two arrays have no common non-null elements and either array contains a null element, the result is null. Otherwise, the result is 0. ``` select arrays_overlap([1, 2, 3], [1, null]); -- result should be 1 select arrays_overlap([2, 3], [1, null]); -- result should be null select arrays_overlap([2, 3], [1]); -- result should be 0 ```
mrhhsg
added a commit
to mrhhsg/doris
that referenced
this pull request
Apr 3, 2025
If the two arrays have the same non-null elements, they are considered overlapping, and the result is 1. If the two arrays have no common non-null elements and either array contains a null element, the result is null. Otherwise, the result is 0. ``` select arrays_overlap([1, 2, 3], [1, null]); -- result should be 1 select arrays_overlap([2, 3], [1, null]); -- result should be null select arrays_overlap([2, 3], [1]); -- result should be 0 ```
yiguolei
pushed a commit
that referenced
this pull request
Apr 4, 2025
Pick #49403 If the two arrays have the same non-null elements, they are considered overlapping, and the result is 1. If the two arrays have no common non-null elements and either array contains a null element, the result is null. Otherwise, the result is 0. ``` select arrays_overlap([1, 2, 3], [1, null]); -- result should be 1 select arrays_overlap([2, 3], [1, null]); -- result should be null select arrays_overlap([2, 3], [1]); -- result should be 0 ``` ### What problem does this PR solve?
dataroaring
pushed a commit
that referenced
this pull request
Apr 9, 2025
PICK #49403 If the two arrays have the same non-null elements, they are considered overlapping, and the result is 1. If the two arrays have no common non-null elements and either array contains a null element, the result is null. Otherwise, the result is 0. ``` select arrays_overlap([1, 2, 3], [1, null]); -- result should be 1 select arrays_overlap([2, 3], [1, null]); -- result should be null select arrays_overlap([2, 3], [1]); -- result should be 0 ```
Closed
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
### What problem does this PR solve? If the two arrays have the same non-null elements, they are considered overlapping, and the result is 1. If the two arrays have no common non-null elements and either array contains a null element, the result is null. Otherwise, the result is 0. ``` select arrays_overlap([1, 2, 3], [1, null]); -- result should be 1 select arrays_overlap([2, 3], [1, null]); -- result should be null select arrays_overlap([2, 3], [1]); -- result should be 0 ```
yiguolei
pushed a commit
to apache/doris-website
that referenced
this pull request
Jul 18, 2025
apache/doris#49403 ## Versions - [x] dev - [ ] 3.0 - [ ] 2.1 - [ ] 2.0 ## Languages - [x] Chinese - [x] English ## Docs Checklist - [ ] Checked by AI - [ ] Test Cases Built
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
If the two arrays have the same non-null elements, they are considered overlapping, and the result is 1.
If the two arrays have no common non-null elements and either array contains a null element, the result is null.
Otherwise, the result is 0.
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)