Skip to content

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Mar 25, 2025

We must add makeSureInitialized() in the fetchRowCount() method to ensure the initialization of catalog related resources.

@Thearas
Copy link
Contributor

Thearas commented Mar 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Mar 25, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zy-kkk
Copy link
Member Author

zy-kkk commented Mar 25, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34105 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e41ba506ae5a66c08807c580d7fa1c09e2b5d25c, data reload: false

------ Round 1 ----------------------------------
q1	26254	5105	5065	5065
q2	2071	298	169	169
q3	10403	1246	698	698
q4	10221	992	530	530
q5	7549	2391	2368	2368
q6	187	162	134	134
q7	923	752	616	616
q8	9321	1316	1085	1085
q9	6872	5127	5189	5127
q10	6811	2315	1903	1903
q11	478	285	261	261
q12	347	355	220	220
q13	17771	3697	3079	3079
q14	238	227	208	208
q15	520	485	478	478
q16	628	609	591	591
q17	581	862	354	354
q18	7782	7238	7113	7113
q19	1208	950	558	558
q20	328	321	195	195
q21	4045	3330	2395	2395
q22	1063	1009	958	958
Total cold run time: 115601 ms
Total hot run time: 34105 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5124	5177	5148	5148
q2	243	324	229	229
q3	2179	2672	2268	2268
q4	1434	1818	1411	1411
q5	4537	4496	4450	4450
q6	211	166	123	123
q7	1951	1912	1729	1729
q8	2597	2605	2510	2510
q9	7221	7242	7338	7242
q10	2948	3191	2785	2785
q11	552	504	492	492
q12	715	765	616	616
q13	3513	3968	3279	3279
q14	288	291	273	273
q15	517	470	480	470
q16	652	691	668	668
q17	1162	1575	1384	1384
q18	7788	7492	7340	7340
q19	819	838	800	800
q20	2011	2038	1909	1909
q21	5249	4767	4657	4657
q22	1074	1028	994	994
Total cold run time: 52785 ms
Total hot run time: 50777 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186694 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e41ba506ae5a66c08807c580d7fa1c09e2b5d25c, data reload: false

query1	996	509	467	467
query2	6550	1929	1891	1891
query3	6786	219	217	217
query4	26980	23398	23750	23398
query5	4370	676	489	489
query6	314	214	188	188
query7	4604	486	268	268
query8	298	251	244	244
query9	8609	2594	2580	2580
query10	499	312	251	251
query11	15430	15223	14900	14900
query12	158	116	111	111
query13	1659	510	415	415
query14	8810	6017	6255	6017
query15	206	183	170	170
query16	7128	671	480	480
query17	925	716	579	579
query18	1984	412	308	308
query19	192	185	166	166
query20	123	122	124	122
query21	216	122	112	112
query22	4151	4215	4183	4183
query23	34178	32996	33099	32996
query24	8490	2371	2393	2371
query25	519	464	390	390
query26	1239	262	150	150
query27	2743	503	341	341
query28	4367	2410	2373	2373
query29	750	552	425	425
query30	287	214	194	194
query31	934	880	754	754
query32	74	60	63	60
query33	547	378	312	312
query34	770	850	493	493
query35	787	834	750	750
query36	932	1014	889	889
query37	121	100	76	76
query38	4145	4109	4123	4109
query39	1502	1409	1414	1409
query40	207	118	104	104
query41	57	54	54	54
query42	116	108	112	108
query43	501	504	466	466
query44	1316	793	793	793
query45	179	170	168	168
query46	831	1032	612	612
query47	1770	1842	1720	1720
query48	384	396	293	293
query49	778	521	427	427
query50	687	720	397	397
query51	4209	4220	4145	4145
query52	103	101	97	97
query53	215	251	178	178
query54	487	495	431	431
query55	82	80	80	80
query56	284	261	250	250
query57	1101	1151	1084	1084
query58	252	245	242	242
query59	2700	2721	2696	2696
query60	279	287	261	261
query61	133	124	125	124
query62	795	717	676	676
query63	219	180	187	180
query64	4263	994	670	670
query65	4411	4252	4302	4252
query66	1139	402	304	304
query67	15917	15493	15431	15431
query68	7664	874	496	496
query69	483	300	267	267
query70	1217	1132	1236	1132
query71	475	315	277	277
query72	5804	4802	4839	4802
query73	722	633	342	342
query74	9141	9045	8858	8858
query75	3874	3260	2728	2728
query76	3737	1189	765	765
query77	788	383	285	285
query78	10248	10247	9241	9241
query79	2188	859	562	562
query80	596	511	451	451
query81	495	258	221	221
query82	478	123	97	97
query83	179	170	153	153
query84	284	95	77	77
query85	768	348	318	318
query86	399	302	301	301
query87	4523	4535	4456	4456
query88	3535	2210	2204	2204
query89	386	316	272	272
query90	1851	210	221	210
query91	147	142	110	110
query92	73	59	62	59
query93	1667	1071	627	627
query94	670	414	318	318
query95	357	271	262	262
query96	479	564	275	275
query97	3131	3238	3164	3164
query98	235	209	199	199
query99	1390	1408	1274	1274
Total cold run time: 274772 ms
Total hot run time: 186694 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.43 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e41ba506ae5a66c08807c580d7fa1c09e2b5d25c, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.10
query3	0.25	0.19	0.20
query4	1.59	0.20	0.20
query5	0.59	0.56	0.60
query6	1.20	0.73	0.71
query7	0.03	0.01	0.02
query8	0.04	0.04	0.03
query9	0.59	0.58	0.52
query10	0.58	0.59	0.57
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.62	0.60	0.60
query14	2.68	2.82	2.74
query15	0.92	0.87	0.85
query16	0.38	0.37	0.42
query17	1.01	1.03	1.02
query18	0.20	0.20	0.19
query19	1.96	1.91	1.82
query20	0.01	0.01	0.01
query21	15.37	0.94	0.55
query22	0.75	1.15	0.65
query23	15.03	1.35	0.64
query24	7.32	1.25	0.95
query25	0.42	0.24	0.12
query26	0.69	0.16	0.13
query27	0.05	0.06	0.05
query28	9.57	0.87	0.44
query29	12.53	3.93	3.30
query30	0.25	0.09	0.07
query31	2.81	0.59	0.39
query32	3.22	0.56	0.46
query33	3.09	3.02	3.10
query34	15.85	5.16	4.55
query35	4.54	4.56	4.56
query36	0.67	0.49	0.49
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.02
query40	0.17	0.15	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 105.77 s
Total hot run time: 31.43 s

@morningman morningman merged commit bd157e6 into apache:master Mar 25, 2025
27 of 29 checks passed
@morningman morningman added the usercase Important user case type label label Mar 25, 2025
github-actions bot pushed a commit that referenced this pull request Mar 25, 2025
…49442)

We must add makeSureInitialized() in the fetchRowCount() method to
ensure the initialization of catalog related resources.
github-actions bot pushed a commit that referenced this pull request Mar 25, 2025
…49442)

We must add makeSureInitialized() in the fetchRowCount() method to
ensure the initialization of catalog related resources.
yiguolei pushed a commit that referenced this pull request Mar 26, 2025
…49442)

We must add makeSureInitialized() in the fetchRowCount() method to
ensure the initialization of catalog related resources.
dataroaring pushed a commit that referenced this pull request Mar 27, 2025
… row count #49442 (#49475)

Cherry-picked from #49442

Co-authored-by: zy-kkk <zhongyk10@gmail.com>
yiguolei pushed a commit that referenced this pull request Mar 29, 2025
… row count #49442 (#49476)

Cherry-picked from #49442

Co-authored-by: zy-kkk <zhongyk10@gmail.com>
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
@zy-kkk zy-kkk deleted the fix_jdbc_row_count_NPE branch April 29, 2025 09:43
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…pache#49442)

We must add makeSureInitialized() in the fetchRowCount() method to
ensure the initialization of catalog related resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.10-merged dev/3.0.5-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants