Skip to content

branch-3.0: [opt](metrics) optimize performance of metrics endpoint #49380 #49454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Mar 27, 2025
Merged

branch-3.0: [opt](metrics) optimize performance of metrics endpoint #49380 #49454

dataroaring merged 1 commit into from
Mar 27, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 25, 2025

Cherry-picked from #49380

@924060929
[opt](metrics) optimize performance of metrics endpoint (#49380)
1f9c408 
the `http://<fe_ip>:<fe_http_port>/metrics` maybe made the frontends
hung, when the threads num too large, this pr replace
`ThreadMXBean.getThreadInfos` to `ThreadMXBean.dumpAllThreads` to
optimize performance

see also:
1. https://issues.apache.org/jira/browse/HADOOP-16850
2. https://bugs.openjdk.org/browse/JDK-8185005
3. apache/skywalking#9190
@github-actions github-actions bot requested a review from dataroaring as a code owner March 25, 2025 06:47
@Thearas
Copy link
Contributor

Thearas commented Mar 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 25, 2025
@Thearas
Copy link
Contributor

Thearas commented Mar 25, 2025

run buildall

dataroaring
dataroaring approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 03cd5f5 into branch-3.0 Mar 27, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49380-branch-3.0 branch March 27, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Thearas @dataroaring @924060929