Skip to content

branch-2.1: [opt](metrics) optimize performance of metrics endpoint #49380 #49455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Mar 26, 2025
Merged

branch-2.1: [opt](metrics) optimize performance of metrics endpoint #49380 #49455

yiguolei merged 1 commit into from
Mar 26, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 25, 2025

Cherry-picked from #49380

@924060929
[opt](metrics) optimize performance of metrics endpoint (#49380)
e608583 
the `http://<fe_ip>:<fe_http_port>/metrics` maybe made the frontends
hung, when the threads num too large, this pr replace
`ThreadMXBean.getThreadInfos` to `ThreadMXBean.dumpAllThreads` to
optimize performance

see also:
1. https://issues.apache.org/jira/browse/HADOOP-16850
2. https://bugs.openjdk.org/browse/JDK-8185005
3. apache/skywalking#9190
@github-actions github-actions bot requested a review from yiguolei as a code owner March 25, 2025 06:48
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 25, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 25, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 25, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 25, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Mar 25, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 0a6bb54 into branch-2.1 Mar 26, 2025
19 of 20 checks passed
@github-actions github-actions bot deleted the auto-pick-49380-branch-2.1 branch March 26, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @yiguolei @dataroaring @924060929