[Fix](RowStore) fix partial columns as row store #49542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. fix the row store columns comparison logic in SchemaChangeHandler. The tests verify the correct behavior when comparing row store columns during ALTER TABLE operations 2. fix partial columns when meet delete sign These tests ensure that the system correctly determines when schema changes are needed when users modify row store column properties through ALTER TABLE statements.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
TPC-H: Total hot run time: 34636 ms |
TPC-DS: Total hot run time: 186198 ms |
ClickBench: Total hot run time: 30.84 s |
Member
Author
|
run buildall |
TPC-H: Total hot run time: 34224 ms |
TPC-DS: Total hot run time: 183389 ms |
ClickBench: Total hot run time: 31.11 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the row store columns comparison logic during schema changes and ensures that partial column modifications are properly handled during ALTER TABLE operations.
- Updated the logic in SchemaChangeHandler to better compare row store columns.
- Modified the behavior in TableProperty to clear row store columns when an empty list is provided.
Reviewed Changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java | Updates the condition and comparison logic for row store columns during schema change detection. |
| fe/fe-core/src/main/java/org/apache/doris/catalog/TableProperty.java | Adjusts setRowStoreColumns to clear row store columns when an empty list is passed. |
Files not reviewed (4)
- be/src/service/point_query_executor.cpp: Language not supported
- regression-test/data/point_query_p0/load.out: Language not supported
- regression-test/suites/point_query_p0/load.groovy: Language not supported
- regression-test/suites/point_query_p0/load_ck.groovy: Language not supported
Comments suppressed due to low confidence (1)
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:1386
- [nitpick] Using a null check on rsColumns may trigger schema change detection even when the list is empty. Consider reinstating an emptiness check if an empty list should be treated as no change.
if (storeRowColumn || rsColumns != null) {
| buildRowStoreColumns(); | ||
| } else { | ||
| // clear row store columns | ||
| this.rowStoreColumns = null; |
There was a problem hiding this comment.
[nitpick] Clearing rowStoreColumns in setRowStoreColumns without updating the underlying properties map may lead to inconsistencies in later reads. Consider also clearing or updating the property key value for full consistency.
Suggested change
| this.rowStoreColumns = null; | |
| this.rowStoreColumns = null; | |
| properties.remove(PropertyAnalyzer.PROPERTIES_ROW_STORE_COLUMNS); |
Contributor
|
PR approved by anyone and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Mar 28, 2025
1. fix the row store columns comparison logic in SchemaChangeHandler. The tests verify the correct behavior when comparing row store columns during ALTER TABLE operations 2. fix partial columns when meet delete sign These tests ensure that the system correctly determines when schema changes are needed when users modify row store column properties through ALTER TABLE statements.
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Mar 28, 2025
1. fix the row store columns comparison logic in SchemaChangeHandler. The tests verify the correct behavior when comparing row store columns during ALTER TABLE operations 2. fix partial columns when meet delete sign These tests ensure that the system correctly determines when schema changes are needed when users modify row store column properties through ALTER TABLE statements.
dataroaring
pushed a commit
that referenced
this pull request
Mar 30, 2025
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
1. fix the row store columns comparison logic in SchemaChangeHandler. The tests verify the correct behavior when comparing row store columns during ALTER TABLE operations 2. fix partial columns when meet delete sign These tests ensure that the system correctly determines when schema changes are needed when users modify row store column properties through ALTER TABLE statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests ensure that the system correctly determines when schema changes are needed when users modify row store column properties through ALTER TABLE statements.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)