Skip to content

[fix](jdbc catalog) Fix connection leak in PostgreSQL JDBC client #49568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 2 commits into from
Apr 2, 2025
Merged

[fix](jdbc catalog) Fix connection leak in PostgreSQL JDBC client #49568

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
158d448
[fix](jdbc catalog) Fix connection leak in PostgreSQL JDBC client
zy-kkk Mar 27, 2025
f5444e6
1
zy-kkk Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions fe/fe-core/src/main/java/org/apache/doris/datasource/jdbc/client/JdbcPostgreSQLClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,26 @@ public List<JdbcFieldSchema> getJdbcColumnsInfo(String remoteDbName, String remo
int arrayDimensions = 0;
if (dataType == Types.ARRAY) {
String columnName = rs.getString("COLUMN_NAME");
try (PreparedStatement pstmt = conn.prepareStatement(
String.format("SELECT array_ndims(%s) FROM %s.%s LIMIT 1",
columnName, remoteDbName, remoteTableName))) {
try (ResultSet arrayRs = pstmt.executeQuery()) {
if (arrayRs.next()) {
arrayDimensions = arrayRs.getInt(1);
PreparedStatement pstmt = null;
ResultSet arrayRs = null;
try {
pstmt = conn.prepareStatement(
String.format("SELECT array_ndims(%s) FROM %s.%s LIMIT 1",
columnName, remoteDbName, remoteTableName));
arrayRs = pstmt.executeQuery();
if (arrayRs.next()) {
arrayDimensions = arrayRs.getInt(1);
}
} catch (SQLException ex) {
LOG.warn("Failed to get array dimensions for column {}: {}",
columnName, Util.getRootCauseMessage(ex));
} finally {
close(arrayRs, null);
if (pstmt != null) {
try {
pstmt.close();
} catch (SQLException ex) {
LOG.warn("Failed to close prepared statement: {}", Util.getRootCauseMessage(ex));
}
}
}
Expand Down