-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](Nereids) fix regression framework compare issue and fix code point count #49575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](Nereids) fix regression framework compare issue and fix code point count #49575
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
5ad1c80 to
2c38e6b
Compare
|
run buildall |
TPC-H: Total hot run time: 34461 ms |
TPC-DS: Total hot run time: 193717 ms |
ClickBench: Total hot run time: 31.53 s |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 34340 ms |
TPC-DS: Total hot run time: 192044 ms |
ClickBench: Total hot run time: 30.66 s |
|
PR approved by at least one committer and no changes requested. |
.../java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java
Outdated
Show resolved
Hide resolved
regression-test/suites/nereids_p0/expression/fold_constant/fold_constant_cast.groovy
Show resolved
Hide resolved
|
run buildall |
TPC-H: Total hot run time: 34067 ms |
ClickBench: Total hot run time: 32.13 s |
|
PR approved by at least one committer and no changes requested. |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
example:
"😊😉".codePointCount(0, 2) ==> 1
"😊😉".offsetByCodePoints(0, 1) ==> 2
because emoji would take two Surrogates to express. So we need to use offsetByCodePoints to express actually length we need
in sql. While it would throw exception, so we need to consider boundary. So every function including offsetByCodePoints need to check boundary before calling it
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)