Skip to content

branch-3.0: [Bug][function] fix the string cast jsonb cause null map have not init value #49810 #49816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 7, 2025
Merged

branch-3.0: [Bug][function] fix the string cast jsonb cause null map have not init value #49810 #49816

dataroaring merged 1 commit into from
Apr 7, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 5, 2025

Cherry-picked from #49810

@HappenLee
[Bug][function] fix the string cast jsonb cause null map have not ini…
214e0a2 
…t value (#49810)

### What problem does this PR solve?

Problem Summary:

if null map value not init, the value can be random cause the wired bug

```
col_null_map_to = ColumnUInt8::create(size, 0);
```

By the way: maybe we should reconsider the api column create force the
init value, but may cause the some performance problem
@github-actions github-actions bot requested a review from dataroaring as a code owner April 5, 2025 10:10
@Thearas
Copy link
Contributor

Thearas commented Apr 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Apr 5, 2025
@dataroaring dataroaring reopened this Apr 5, 2025
@Thearas
Copy link
Contributor

Thearas commented Apr 5, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 5, 2025

TPC-H: Total hot run time: 39831 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 214e0a24c3d6edc797edcafc6d1bb604e49a62b2, data reload: false

------ Round 1 ----------------------------------
q1	17579	6747	6542	6542
q2	2067	171	176	171
q3	10612	1090	1093	1090
q4	10577	732	761	732
q5	7748	2813	2805	2805
q6	220	133	132	132
q7	970	595	609	595
q8	9343	1943	2010	1943
q9	6610	6399	6390	6390
q10	7017	2271	2301	2271
q11	466	256	253	253
q12	395	208	205	205
q13	17804	2995	3110	2995
q14	248	232	233	232
q15	518	500	462	462
q16	666	607	600	600
q17	988	595	626	595
q18	7482	6777	6579	6579
q19	1390	1128	954	954
q20	482	200	207	200
q21	3982	3265	3111	3111
q22	1076	974	1010	974
Total cold run time: 108240 ms
Total hot run time: 39831 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6573	6529	6583	6529
q2	340	233	229	229
q3	2893	2734	2874	2734
q4	2064	1825	1803	1803
q5	5788	5782	5721	5721
q6	207	123	126	123
q7	2206	1831	1820	1820
q8	3415	3509	3513	3509
q9	8838	8894	8832	8832
q10	3559	3531	3508	3508
q11	583	489	493	489
q12	812	588	600	588
q13	9872	3223	3166	3166
q14	302	271	281	271
q15	518	467	472	467
q16	699	653	682	653
q17	1834	1627	1636	1627
q18	8387	7667	7731	7667
q19	1662	1474	1515	1474
q20	2100	1838	1866	1838
q21	5556	5367	5261	5261
q22	1111	1017	996	996
Total cold run time: 69319 ms
Total hot run time: 59305 ms

@doris-robot
Copy link

doris-robot commented Apr 5, 2025

TPC-DS: Total hot run time: 197641 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 214e0a24c3d6edc797edcafc6d1bb604e49a62b2, data reload: false

query1	1305	909	880	880
query2	6234	1938	1966	1938
query3	10766	4272	4403	4272
query4	60457	28450	23298	23298
query5	5158	472	446	446
query6	399	175	172	172
query7	5478	320	301	301
query8	293	212	223	212
query9	8492	2615	2595	2595
query10	466	283	254	254
query11	17704	15213	15697	15213
query12	163	105	103	103
query13	1438	452	449	449
query14	10573	7531	7329	7329
query15	206	179	174	174
query16	7088	500	489	489
query17	1218	579	576	576
query18	1931	312	317	312
query19	213	157	159	157
query20	118	110	109	109
query21	208	120	107	107
query22	4851	4377	4722	4377
query23	34470	34029	34413	34029
query24	6201	2946	2860	2860
query25	504	412	388	388
query26	645	167	167	167
query27	1894	357	371	357
query28	4055	2476	2429	2429
query29	687	468	429	429
query30	254	164	166	164
query31	1031	823	840	823
query32	69	55	57	55
query33	422	292	298	292
query34	908	506	528	506
query35	848	747	734	734
query36	1097	971	984	971
query37	114	66	67	66
query38	4185	4072	4109	4072
query39	1495	1627	1477	1477
query40	198	101	99	99
query41	49	50	49	49
query42	115	102	102	102
query43	531	499	488	488
query44	1183	808	822	808
query45	188	167	167	167
query46	1142	754	756	754
query47	2037	1930	1927	1927
query48	489	428	384	384
query49	735	379	390	379
query50	816	436	425	425
query51	7470	7201	7225	7201
query52	100	91	93	91
query53	267	189	188	188
query54	589	476	474	474
query55	78	79	83	79
query56	290	233	242	233
query57	1245	1179	1162	1162
query58	224	205	215	205
query59	3348	3022	2847	2847
query60	272	260	257	257
query61	109	108	109	108
query62	775	663	681	663
query63	214	190	190	190
query64	1381	680	636	636
query65	3264	3164	3189	3164
query66	722	302	323	302
query67	16090	15960	15742	15742
query68	4265	571	569	569
query69	422	279	274	274
query70	1190	1151	1042	1042
query71	353	252	263	252
query72	6371	4168	4142	4142
query73	758	346	358	346
query74	10089	9267	9178	9178
query75	3348	2646	2678	2646
query76	2107	1051	1066	1051
query77	502	277	277	277
query78	10452	9668	9541	9541
query79	2180	610	604	604
query80	1376	447	429	429
query81	529	239	235	235
query82	1215	88	89	88
query83	275	145	148	145
query84	284	87	82	82
query85	1018	304	293	293
query86	389	305	298	298
query87	4472	4332	4389	4332
query88	3672	2401	2376	2376
query89	413	295	296	295
query90	1996	186	186	186
query91	179	146	149	146
query92	65	51	52	51
query93	2739	543	553	543
query94	775	295	296	295
query95	363	256	256	256
query96	621	276	282	276
query97	3294	3190	3223	3190
query98	216	199	201	199
query99	1594	1300	1298	1298
Total cold run time: 315081 ms
Total hot run time: 197641 ms

@doris-robot
Copy link

doris-robot commented Apr 5, 2025

ClickBench: Total hot run time: 31.97 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 214e0a24c3d6edc797edcafc6d1bb604e49a62b2, data reload: false

query1	0.03	0.03	0.02
query2	0.07	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.50	0.52	0.50
query6	1.13	0.73	0.72
query7	0.02	0.02	0.02
query8	0.04	0.05	0.04
query9	0.57	0.51	0.50
query10	0.57	0.56	0.56
query11	0.14	0.10	0.09
query12	0.16	0.11	0.10
query13	0.60	0.60	0.59
query14	2.75	2.74	2.73
query15	0.90	0.81	0.82
query16	0.38	0.38	0.38
query17	1.06	1.05	1.02
query18	0.23	0.21	0.21
query19	1.95	1.79	2.02
query20	0.01	0.00	0.01
query21	15.38	0.57	0.58
query22	2.74	1.86	2.00
query23	17.06	0.83	0.91
query24	2.92	0.98	0.91
query25	0.16	0.09	0.07
query26	0.52	0.14	0.13
query27	0.05	0.04	0.05
query28	10.73	0.52	0.48
query29	12.62	3.24	3.24
query30	0.24	0.06	0.06
query31	2.84	0.38	0.39
query32	3.26	0.47	0.44
query33	2.95	2.98	2.99
query34	17.15	4.44	4.46
query35	4.55	4.49	4.50
query36	0.70	0.50	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 107.3 s
Total hot run time: 31.97 s

dataroaring
dataroaring approved these changes Apr 7, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 9ad7d6d into branch-3.0 Apr 7, 2025
21 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49810-branch-3.0 branch April 7, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @dataroaring @HappenLee