-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Optimize]Take all scan nodes of one sql into consideration when select host for a tablet #4984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
caiconghui
merged 39 commits into
apache:master
from
xinghuayu007:global_optimize_select_host
Jan 15, 2021
Merged
[Optimize]Take all scan nodes of one sql into consideration when select host for a tablet #4984
caiconghui
merged 39 commits into
apache:master
from
xinghuayu007:global_optimize_select_host
Jan 15, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@xinghuayu007 please resolve conflict firstly |
Contributor
Author
done |
caiconghui
previously approved these changes
Jan 11, 2021
Contributor
caiconghui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
caiconghui
reviewed
Jan 14, 2021
fe/fe-core/src/test/java/org/apache/doris/qe/CoordinatorTest.java
Outdated
Show resolved
Hide resolved
caiconghui
approved these changes
Jan 15, 2021
Contributor
caiconghui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
EmmyMiao87
pushed a commit
to EmmyMiao87/incubator-doris
that referenced
this pull request
Jan 26, 2021
…ct host for a tablet (apache#4984) Currently when a scan node scans many tablets, Doris will assure it load balance when choosing which replica for scan task to be executed. But it does not take other scan nodes into consideration to implement a global load balance. This patch tries to make all tables of all scan nodes to be load balance. Co-authored-by: wangxixu <wangxixu@xiaomi.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently when a scan node scans many tablets, Doris will assure it load balance when choosing which replica for scan task to be executed. But it does not take other scan nodes into consideration to implement a global load balance. This patch tries to make all tables of all scan nodes to be load balance.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...