Skip to content

branch-3.0: [fix](multi-catalog) Fix multi-thread issue in hive/iceberg writer commit meta-info to fe. #49842 #49863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 11, 2025
Merged

branch-3.0: [fix](multi-catalog) Fix multi-thread issue in hive/iceberg writer commit meta-info to fe. #49842 #49863

dataroaring merged 1 commit into from
Apr 11, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 8, 2025

Cherry-picked from #49842

@kaka11chen
[fix](multi-catalog) Fix multi-thread issue in hive/iceberg writer co…
a09f85a 
…mmit meta-info to fe. (#49842)

### What problem does this PR solve?

Related PR: #48709

Problem Summary:

Refer to the changes in #48709. In hive/iceberg writer, the information
related to `partiton_update_info` and `iceberg_commit_data` will be
submitted to FE for processing. However, there will be multiple threads
accessing the related vectors, so thread-safe processing is required.
@github-actions github-actions bot requested a review from dataroaring as a code owner April 8, 2025 03:13
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Apr 8, 2025
@dataroaring dataroaring reopened this Apr 8, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 8, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 8, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/30) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.24% (10280/26198)
Line Coverage 30.61% (87815/286915)
Region Coverage 29.64% (45134/152254)
Branch Coverage 26.15% (22982/87872)

dataroaring
dataroaring approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 11, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 11, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 11, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit c5e18ef into branch-3.0 Apr 11, 2025
21 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49842-branch-3.0 branch April 11, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @dataroaring @kaka11chen