Skip to content

[fix] (inverted index) Disallow variant columns from using inverted index format v1 (#49823) #49890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 9, 2025
Merged

[fix] (inverted index) Disallow variant columns from using inverted index format v1 (#49823) #49890

dataroaring merged 1 commit into from
Apr 9, 2025

Conversation

@csun5285
Copy link
Contributor

@csun5285 csun5285 commented Apr 9, 2025

pick from master #49823

@csun5285 csun5285 requested a review from dataroaring as a code owner April 9, 2025 02:33
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@csun5285
Copy link
Contributor Author

csun5285 commented Apr 9, 2025

run buildall

1 similar comment
@csun5285
Copy link
Contributor Author

csun5285 commented Apr 9, 2025

run buildall

@csun5285
[fix] (inverted index) Disallow variant columns from using inverted i…
30ef05a 
…ndex format v1 (apache#49823)

Problem Summary:

Disallow variant columns from using inverted index format v1

fix confilct

fix
@csun5285 csun5285 force-pushed the pick_49844_master branch from 2960fb7 to 30ef05a Compare April 9, 2025 04:08
@csun5285
Copy link
Contributor Author

csun5285 commented Apr 9, 2025

run buildall

dataroaring
dataroaring approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit d2cae4d into apache:branch-3.0 Apr 9, 2025
20 of 23 checks passed
@gavinchou gavinchou mentioned this pull request Apr 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@csun5285 @hello-stephen @dataroaring