Skip to content

Conversation

@FlowerSaid
Copy link
Contributor

… the return type of method ‘str_to_date’ to the actual type datetime;3,In the header information returned by mysql, the data type length is returned according to the actual type.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • [] Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

… the return type of method ‘str_to_date’ to the actual type datetime;3,In the header information returned by mysql, the data type length is returned according to the actual type.
@morningman morningman changed the title 1,Add metadata table ‘statistics’ to store index information;2,Modify… [Enhance] Add "statistics" meta table and fix some mysql compatibility problem Dec 1, 2020
@morningman morningman added area/mysql-compatibility Issues or PRs related to the mysql compatibility kind/improvement labels Dec 1, 2020
case DECIMAL:
case DECIMALV2:
return MysqlColType.MYSQL_TYPE_DECIMAL;
// update by songchuanyuan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove author name, it is not necessary

* @return
* @add by songchuanyuan
*/
public boolean getTimeType() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public boolean getTimeType() {
public boolean isTimeType() {

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 1ae6de7 into apache:master Dec 3, 2020
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
@FlowerSaid FlowerSaid deleted the songdev branch August 20, 2021 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/mysql-compatibility Issues or PRs related to the mysql compatibility kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants