Skip to content

[fix](replica) skip missing version should care catchup #49999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gavinchou merged 2 commits into from
Apr 16, 2025
Merged

[fix](replica) skip missing version should care catchup #49999

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d980d4
[fix](replica) skip missing version should care catchup
Apr 12, 2025
46efe5c
resolve comment
Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions fe/fe-core/src/main/java/org/apache/doris/catalog/Tablet.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,23 +303,29 @@ protected Multimap<Long, Long> getNormalReplicaBackendPathMapCloud(String beEndp
(rep, be) -> ((CloudReplica) rep).getBackendId(be));
}

// When a BE reports a missing version, lastFailedVersion is set. When a write fails on a replica,
// lastFailedVersion is set.
// for query
public List<Replica> getQueryableReplicas(long visibleVersion, Map<Long, Set<Long>> backendAlivePathHashs,
boolean allowFailedVersion) {
boolean allowMissingVersion) {
List<Replica> allQueryableReplica = Lists.newArrayListWithCapacity(replicas.size());
List<Replica> auxiliaryReplica = Lists.newArrayListWithCapacity(replicas.size());
List<Replica> deadPathReplica = Lists.newArrayList();
List<Replica> mayMissingVersionReplica = Lists.newArrayList();
List<Replica> notCatchupReplica = Lists.newArrayList();

for (Replica replica : replicas) {
if (replica.isBad()) {
continue;
}

// Skip the missing version replica
Copy link
Contributor

@yujun777 yujun777 Apr 14, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not allow missing version, must check last fail version < 0, line 318 ~ 321 cannot deleted, keep it

if (replica.getLastFailedVersion() > 0 && !allowFailedVersion) {
if (replica.getLastFailedVersion() > 0) {
mayMissingVersionReplica.add(replica);
continue;
}

if (!replica.checkVersionCatchUp(visibleVersion, false)) {
Copy link
Contributor

@yujun777 yujun777 Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if be not found rowset [1, visible version], be maybe also throw a error

notCatchupReplica.add(replica);
continue;
}

Expand All @@ -345,6 +351,15 @@ public List<Replica> getQueryableReplicas(long visibleVersion, Map<Long, Set<Lon
allQueryableReplica = deadPathReplica;
}

if (allQueryableReplica.isEmpty()) {
// If be misses a version, be would report failure.
allQueryableReplica = mayMissingVersionReplica;
}

if (allQueryableReplica.isEmpty() && allowMissingVersion) {
allQueryableReplica = notCatchupReplica;
}

if (Config.skip_compaction_slower_replica && allQueryableReplica.size() > 1) {
long minVersionCount = allQueryableReplica.stream().mapToLong(Replica::getVisibleVersionCount)
.filter(count -> count != -1).min().orElse(Long.MAX_VALUE);
Expand Down
Loading