-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](ut) fix unstable FE ut case for schema change job #50350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an unstable front-end unit test case for the schema change job by conditionally bypassing certain operations in unit test environments.
- Wraps edit log writing and task submission calls with a check on FeConstants.runningUnitTest.
- Applies the condition in multiple methods: runPendingJob, runWaitingTxnJob, runRunningJob, and cancelImpl.
TPC-H: Total hot run time: 33961 ms |
TPC-DS: Total hot run time: 185270 ms |
ClickBench: Total hot run time: 29.65 s |
|
PR approved by anyone and no changes requested. |
|
PR approved by at least one committer and no changes requested. |
|
run buildall |
TPC-H: Total hot run time: 34068 ms |
TPC-DS: Total hot run time: 185407 ms |
ClickBench: Total hot run time: 29.44 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 34943 ms |
TPC-DS: Total hot run time: 192967 ms |
ClickBench: Total hot run time: 30.05 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)