Skip to content

Conversation

@morningman
Copy link
Contributor

bp #49238

Add third party library [pugixml](https://github.com/zeux/pugixml) to
impl functions xpath_string
@morningman morningman requested a review from dataroaring as a code owner April 24, 2025 18:34
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40037 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d2702a44b5bfa01c38567f51a60fe3226b53dbbb, data reload: false

------ Round 1 ----------------------------------
q1	17617	6685	6547	6547
q2	2058	166	175	166
q3	11150	1095	1165	1095
q4	10585	714	763	714
q5	7827	2889	2821	2821
q6	220	139	135	135
q7	982	628	609	609
q8	9375	1953	2079	1953
q9	6687	6418	6400	6400
q10	7001	2265	2302	2265
q11	458	265	260	260
q12	395	213	216	213
q13	17804	2959	2994	2959
q14	225	205	211	205
q15	507	466	470	466
q16	689	585	584	584
q17	960	583	569	569
q18	7078	6613	6677	6613
q19	1431	1116	1042	1042
q20	466	197	199	197
q21	4168	3333	3236	3236
q22	1130	988	1000	988
Total cold run time: 108813 ms
Total hot run time: 40037 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6600	6577	6542	6542
q2	326	229	224	224
q3	2887	2761	2948	2761
q4	2055	1856	1800	1800
q5	5745	5725	5683	5683
q6	208	126	127	126
q7	2234	1830	1809	1809
q8	3396	3549	3497	3497
q9	8921	8878	8861	8861
q10	3553	3498	3475	3475
q11	591	505	504	504
q12	841	583	623	583
q13	7440	3190	3164	3164
q14	307	286	286	286
q15	512	474	477	474
q16	702	640	630	630
q17	1831	1614	1623	1614
q18	8033	7698	7563	7563
q19	1706	1629	1510	1510
q20	2037	1818	1827	1818
q21	5441	5374	5217	5217
q22	1174	1069	1038	1038
Total cold run time: 66540 ms
Total hot run time: 59179 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.22% (10556/26247)
Line Coverage 30.99% (89302/288206)
Region Coverage 30.11% (46057/152977)
Branch Coverage 26.62% (23545/88462)

@doris-robot
Copy link

TPC-DS: Total hot run time: 197300 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d2702a44b5bfa01c38567f51a60fe3226b53dbbb, data reload: false

query1	1278	904	882	882
query2	6330	1993	2022	1993
query3	10940	4450	4595	4450
query4	62132	29463	23381	23381
query5	5131	459	451	451
query6	404	188	191	188
query7	5471	337	318	318
query8	303	222	212	212
query9	8595	2703	2673	2673
query10	461	271	252	252
query11	17805	15188	15671	15188
query12	161	111	111	111
query13	1430	463	435	435
query14	10791	6839	6650	6650
query15	199	184	178	178
query16	7297	497	497	497
query17	1126	585	580	580
query18	1806	331	304	304
query19	209	158	162	158
query20	114	109	109	109
query21	211	104	102	102
query22	4763	4749	4536	4536
query23	34570	33974	33953	33953
query24	6107	2874	2930	2874
query25	510	423	440	423
query26	661	177	172	172
query27	1849	347	366	347
query28	4370	2496	2489	2489
query29	699	474	455	455
query30	237	164	162	162
query31	1006	833	855	833
query32	72	62	60	60
query33	417	309	290	290
query34	902	503	529	503
query35	865	747	729	729
query36	1078	958	940	940
query37	125	68	74	68
query38	4136	4054	4025	4025
query39	1548	1448	1513	1448
query40	210	103	112	103
query41	52	52	51	51
query42	123	106	105	105
query43	537	501	509	501
query44	1184	852	831	831
query45	184	165	168	165
query46	1145	734	728	728
query47	2058	1934	1924	1924
query48	480	438	395	395
query49	768	426	416	416
query50	848	443	455	443
query51	7425	7319	7280	7280
query52	107	92	94	92
query53	271	191	185	185
query54	582	484	497	484
query55	79	77	73	73
query56	260	249	249	249
query57	1261	1197	1166	1166
query58	218	214	230	214
query59	3221	2995	2922	2922
query60	268	246	257	246
query61	111	108	108	108
query62	769	678	678	678
query63	214	188	186	186
query64	1358	675	647	647
query65	3252	3231	3168	3168
query66	690	299	294	294
query67	15971	15615	15575	15575
query68	4215	598	578	578
query69	438	271	265	265
query70	1188	1111	1142	1111
query71	360	268	263	263
query72	6220	4196	4138	4138
query73	744	355	357	355
query74	10186	9223	8902	8902
query75	3363	2631	2661	2631
query76	1795	993	1033	993
query77	501	275	280	275
query78	10608	9664	9605	9605
query79	1656	598	600	598
query80	1458	420	420	420
query81	537	242	238	238
query82	1235	86	86	86
query83	280	146	139	139
query84	287	83	85	83
query85	1013	329	293	293
query86	409	284	297	284
query87	4580	4342	4282	4282
query88	3795	2442	2427	2427
query89	421	291	282	282
query90	1953	187	185	185
query91	181	151	150	150
query92	59	49	50	49
query93	2109	573	578	573
query94	827	301	314	301
query95	362	260	261	260
query96	610	288	282	282
query97	3281	3164	3127	3127
query98	205	195	203	195
query99	1620	1284	1282	1282
Total cold run time: 316251 ms
Total hot run time: 197300 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.67 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d2702a44b5bfa01c38567f51a60fe3226b53dbbb, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.07
query4	1.62	0.10	0.10
query5	0.53	0.51	0.52
query6	1.13	0.74	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.59	0.50	0.50
query10	0.56	0.54	0.54
query11	0.14	0.11	0.10
query12	0.14	0.11	0.11
query13	0.60	0.60	0.59
query14	2.72	2.84	2.84
query15	0.91	0.82	0.83
query16	0.39	0.37	0.39
query17	1.05	1.06	1.09
query18	0.24	0.23	0.23
query19	1.95	1.84	1.98
query20	0.01	0.01	0.01
query21	15.36	0.61	0.58
query22	2.24	3.01	2.52
query23	17.01	0.88	0.74
query24	3.56	1.51	1.90
query25	0.19	0.25	0.12
query26	0.52	0.13	0.14
query27	0.04	0.04	0.04
query28	8.76	0.53	0.53
query29	12.63	3.25	3.26
query30	0.24	0.06	0.06
query31	2.86	0.39	0.38
query32	3.24	0.47	0.45
query33	3.00	3.03	3.04
query34	17.19	4.49	4.51
query35	4.52	4.55	4.57
query36	0.68	0.48	0.47
query37	0.09	0.07	0.06
query38	0.05	0.03	0.04
query39	0.04	0.03	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.5 s
Total hot run time: 33.67 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 790ab9e into apache:branch-3.0 Apr 25, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants