Skip to content

Conversation

@hubgeter
Copy link
Contributor

@hubgeter hubgeter commented Apr 25, 2025

pick #49958

@hubgeter hubgeter requested a review from dataroaring as a code owner April 25, 2025 06:51
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hubgeter
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 83.00% (1084/1306)
Line Coverage: 65.96% (17940/27198)
Region Coverage: 65.48% (8847/13511)
Branch Coverage: 55.44% (4779/8620)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1765c33ad72e9d9d07a68212b3896835ab35e307_1765c33ad72e9d9d07a68212b3896835ab35e307_cloud/report/index.html

@hubgeter
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 83.05% (1088/1310)
Line Coverage: 66.01% (18011/27285)
Region Coverage: 65.51% (8866/13534)
Branch Coverage: 55.44% (4788/8636)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c9426885c73ff8af9f878eb5566a59af2db78d36_c9426885c73ff8af9f878eb5566a59af2db78d36_cloud/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 40499 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c9426885c73ff8af9f878eb5566a59af2db78d36, data reload: false

------ Round 1 ----------------------------------
q1	17577	6865	6736	6736
q2	2061	176	192	176
q3	10609	1067	1125	1067
q4	10483	765	797	765
q5	7776	2869	2864	2864
q6	224	135	131	131
q7	984	620	607	607
q8	9364	2017	2045	2017
q9	6652	6435	6446	6435
q10	6983	2319	2340	2319
q11	470	269	260	260
q12	417	214	213	213
q13	17812	2996	2985	2985
q14	236	226	219	219
q15	524	460	479	460
q16	691	623	582	582
q17	997	632	573	573
q18	7423	6779	6714	6714
q19	1404	1166	1000	1000
q20	500	205	204	204
q21	4015	3346	3173	3173
q22	1054	999	1007	999
Total cold run time: 108256 ms
Total hot run time: 40499 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6647	6597	6613	6597
q2	339	238	233	233
q3	2896	2770	2945	2770
q4	2069	1800	1860	1800
q5	5778	5749	5746	5746
q6	215	128	128	128
q7	2242	1835	1809	1809
q8	3381	3602	3571	3571
q9	8966	8849	8900	8849
q10	3569	3534	3570	3534
q11	599	497	512	497
q12	843	637	614	614
q13	8388	3133	3252	3133
q14	308	266	268	266
q15	503	467	480	467
q16	682	667	683	667
q17	1872	1629	1619	1619
q18	8301	7818	7716	7716
q19	1702	1653	1625	1625
q20	2101	1795	1833	1795
q21	5589	5307	5350	5307
q22	1143	1051	1015	1015
Total cold run time: 68133 ms
Total hot run time: 59758 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198670 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c9426885c73ff8af9f878eb5566a59af2db78d36, data reload: false

query1	1291	915	907	907
query2	6328	2070	1995	1995
query3	10800	4400	4319	4319
query4	60742	29658	23567	23567
query5	5201	452	429	429
query6	406	178	184	178
query7	5451	319	308	308
query8	315	237	228	228
query9	8585	2640	2618	2618
query10	470	279	247	247
query11	17811	15265	15651	15265
query12	164	105	105	105
query13	1466	500	446	446
query14	9878	7433	7494	7433
query15	196	183	194	183
query16	7218	505	465	465
query17	1125	597	605	597
query18	1972	326	321	321
query19	214	165	162	162
query20	130	114	116	114
query21	205	103	108	103
query22	4730	4531	4517	4517
query23	35037	34352	34285	34285
query24	6203	2971	2900	2900
query25	521	412	405	405
query26	666	165	162	162
query27	2199	354	348	348
query28	4306	2480	2488	2480
query29	702	448	427	427
query30	242	160	168	160
query31	996	814	834	814
query32	65	56	57	56
query33	487	285	290	285
query34	940	529	512	512
query35	870	722	740	722
query36	1090	955	931	931
query37	120	68	69	68
query38	4095	4066	4016	4016
query39	1512	1446	1475	1446
query40	212	98	97	97
query41	50	50	48	48
query42	116	103	101	101
query43	544	492	483	483
query44	1220	857	850	850
query45	193	170	169	169
query46	1159	734	749	734
query47	2061	1932	1941	1932
query48	479	392	393	392
query49	752	437	414	414
query50	872	442	443	442
query51	7508	7289	7447	7289
query52	106	91	91	91
query53	261	189	185	185
query54	575	481	472	472
query55	80	80	79	79
query56	289	257	268	257
query57	1282	1171	1171	1171
query58	235	221	228	221
query59	3285	3180	2965	2965
query60	307	271	274	271
query61	137	138	130	130
query62	793	718	696	696
query63	225	190	193	190
query64	1419	689	673	673
query65	3257	3187	3207	3187
query66	704	307	305	305
query67	15861	15514	15520	15514
query68	4156	602	589	589
query69	444	266	260	260
query70	1154	1140	1141	1140
query71	355	269	266	266
query72	6449	3956	4149	3956
query73	755	349	369	349
query74	10582	9226	9156	9156
query75	3344	2669	2662	2662
query76	2306	1078	1055	1055
query77	495	296	279	279
query78	10685	9575	9556	9556
query79	1618	601	591	591
query80	1114	428	447	428
query81	537	242	240	240
query82	1297	88	90	88
query83	260	150	144	144
query84	283	84	84	84
query85	902	345	300	300
query86	331	306	303	303
query87	4413	4271	4236	4236
query88	3809	2419	2389	2389
query89	419	294	298	294
query90	2018	185	184	184
query91	184	147	151	147
query92	68	49	49	49
query93	2090	577	571	571
query94	755	279	295	279
query95	364	255	263	255
query96	629	292	286	286
query97	3355	3153	3155	3153
query98	219	202	201	201
query99	1617	1322	1298	1298
Total cold run time: 315738 ms
Total hot run time: 198670 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.21% (10558/26256)
Line Coverage 30.98% (89355/288415)
Region Coverage 30.11% (46093/153063)
Branch Coverage 26.63% (23570/88514)

@doris-robot
Copy link

ClickBench: Total hot run time: 33.65 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c9426885c73ff8af9f878eb5566a59af2db78d36, data reload: false

query1	0.03	0.02	0.03
query2	0.09	0.05	0.04
query3	0.24	0.07	0.05
query4	1.63	0.08	0.08
query5	0.52	0.49	0.51
query6	1.12	0.74	0.75
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.56	0.50	0.50
query10	0.56	0.57	0.57
query11	0.17	0.12	0.12
query12	0.17	0.13	0.12
query13	0.60	0.59	0.60
query14	2.74	2.77	2.86
query15	0.91	0.83	0.85
query16	0.37	0.36	0.37
query17	1.05	1.05	1.02
query18	0.18	0.19	0.19
query19	1.95	1.89	1.96
query20	0.01	0.02	0.01
query21	15.35	0.67	0.67
query22	4.05	6.53	2.52
query23	18.26	1.56	1.37
query24	2.31	0.22	0.23
query25	0.16	0.09	0.08
query26	0.27	0.18	0.18
query27	0.09	0.08	0.08
query28	13.20	0.60	0.61
query29	12.62	3.41	3.36
query30	0.24	0.06	0.05
query31	2.85	0.41	0.40
query32	3.23	0.48	0.49
query33	3.02	3.09	3.03
query34	16.86	4.52	4.49
query35	4.56	4.58	4.60
query36	0.67	0.52	0.49
query37	0.21	0.17	0.16
query38	0.18	0.15	0.16
query39	0.05	0.05	0.04
query40	0.16	0.13	0.12
query41	0.10	0.05	0.04
query42	0.07	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 111.52 s
Total hot run time: 33.65 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 28, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 3152752 into apache:branch-3.0 Apr 29, 2025
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants