Forbidden creating table with dynamic partition when FE.config dynamic_partition_enable=false #5043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
reviewed
Dec 14, 2020
Contributor
morningman
left a comment
morningman
left a comment
There was a problem hiding this comment.
We also need to forbid creating hour partition for date type column
morningman
reviewed
Dec 14, 2020
Contributor
morningman
left a comment
morningman
left a comment
There was a problem hiding this comment.
We also need to forbid creating hour partition for date type column
…c_partition_enable=false
- There is a fe configuration called dynamic_partition_enable
which controls the opening and closing of the dynamic partition function.
When this configuration is false, it means that all tables do not support dynamic partitioning.
- But when the user tried to create the dynamic partition table, Doris did not detect this parameter.
This will cause the user can normally create a dynamic partition table,
but in fact Doris cannot create a partition for this table.
- This pr detect this config when building the table.
The dynamic partition table can be created only when the dynamic_partition_enable configuration is true.
If the configuration is false, the command to create a dynamic partition table will directly report an error.
Fixed apache#5042
- When the user-specified dynamic partition time unit is hour,
Doris will divide the partition every hour and automatically create and delete it.
But if the data type of the specified partition column is DATE when the user creates the table,
the partition creation will fail.
Because the time accuracy of the date type is only up to days, the data cannot be divided by hour.
- So this pr directly prohibits this behavior when creating the table.
EmmyMiao87
force-pushed
the
dynamic_partition
branch
from
0eae2a9 to
b0d9bd1
Compare
morningman
pushed a commit
to baidu-doris/incubator-doris
that referenced
this pull request
Jan 5, 2021
…dynamic_partition_enable=false (apache#5043) - There is a fe configuration called dynamic_partition_enable which controls the opening and closing of the dynamic partition function. When this configuration is false, it means that all tables do not support dynamic partitioning. - But when the user tried to create the dynamic partition table, Doris did not detect this parameter. This will cause the user can normally create a dynamic partition table, but in fact Doris cannot create a partition for this table. - This pr detect this config when building the table. The dynamic partition table can be created only when the dynamic_partition_enable configuration is true. If the configuration is false, the command to create a dynamic partition table will directly report an error.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
There is a fe configuration called dynamic_partition_enable
which controls the opening and closing of the dynamic partition function.
When this configuration is false, it means that all tables do not support dynamic partitioning.
But when the user tried to create the dynamic partition table, Doris did not detect this parameter.
This will cause the user can normally create a dynamic partition table,
but in fact Doris cannot create a partition for this table.
This pr detect this config when building the table.
The dynamic partition table can be created only when the dynamic_partition_enable configuration is true.
If the configuration is false, the command to create a dynamic partition table will directly report an error.
Fixed #5042
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...