branch-2.1: [fix](catalog) do cache load when cache value is not present #50188 #50451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
run buildall |
Contributor
|
run buildall |
### What problem does this PR solve? The MetaCache is used to cache the external table instance, like hive table. The type of cache value is `Optional<Table>`. When first loading a key, if the key does not exist(table not exists), the cacheloader will return `null`, and finally there will be a cache entry `<key, EmptyOptional>` in cache. So when the second time to get this key from cache, the cache will return the `EmptyOptional` instead of try loading this key again from remote datasource. But what we expect is to try loading the key from remote datasource if it does not exist in cache. So we need check the return result of the cache, if return result is `null` or `EmptyOptional`, we should load the key again. Otherwise, the following case may be failed: 1. select a non-exist hive table in Doris. 2. create the table in Hive. 3. select the table in Doris, expect to get table succeed, but still return "table does not exist".
morningman
force-pushed
the
auto-pick-50188-branch-2.1
branch
from
aaf8316 to
b0c6941
Compare
Contributor
|
run buildall |
Contributor
|
run buildall |
yiguolei
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #50188