Skip to content

Conversation

@Dam1029
Copy link
Contributor

@Dam1029 Dam1029 commented Dec 9, 2020

Proposed changes

  • When we use spark load from hive table,the function loadDataFromHiveTable will read whole hive table and then filter the data in process(),if hive table have lots of partitions and history data,the load will be cost too much time and resource. So we can do filter work in loadDataFromHiveTable function when read from hive table.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added approved Indicates a PR has been approved by one committer. area/spark-load Issues or PRs related to the spark load kind/improvement labels Dec 14, 2020
@morningman morningman merged commit 834834d into apache:master Dec 15, 2020
morningman pushed a commit to baidu-doris/incubator-doris that referenced this pull request Jan 5, 2021
…he#5047)

When we use spark load from hive table, the function loadDataFromHiveTable
will read whole hive table and then filter the data in process()
if hive table have lots of partitions and history data,the load will be cost too much time and resource.
So we can do filter work in loadDataFromHiveTable function when read from hive table.
Co-authored-by: 杜安明 <anming.du@mihoyo.com>
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/spark-load Issues or PRs related to the spark load kind/improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants