[fix](audit) fix potential audit log missing issue (#50357) #50501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem Summary: After query finished, the audit event will be created and: 1. Try to put into `queryAuditEventList` in `WorkloadRuntimeStatusMgr` `WorkloadRuntimeStatusMgr` has a background thread to visit `queryAuditEventList`, try to wait for the statistic info of the event(such as scan rows, cpu time, etc.) before logging this event. The size of `queryAuditEventList` is very large, default is `250000`, which is configured by FE config `audit_event_log_queue_size`. So that it can always hold all events within a certain period (typically, 5 seconds). 2. If `queryAuditEventList` is full, the statistic info of this audit event will be ignored, and event will be logged directly. Either the event has the statistic info or not, it will be put into a `eventQueue` in `AuditEventProcessor`. But this queue only has capacity of `10000`, which may not enough to cache all events in a certain periods. So some of audit event will be discarded and lost. This PR mainly changes: 1. Use the same config `audit_event_log_queue_size` as the max size of `eventQueue`. 2. Change some log message for easy debugging in future.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
yiguolei
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bp #50357