Skip to content

branch-2.1: [fix](path gc) Fix path gc race with publish task #50343 #50520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Apr 29, 2025
Merged

branch-2.1: [fix](path gc) Fix path gc race with publish task #50343 #50520

yiguolei merged 1 commit into from
Apr 29, 2025

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Apr 28, 2025

cherry pick from #50343

@deardeng
[fix](path gc) Fix path gc race with publish task (apache#50343)
edae705 
Fix path gc race with publish task and checkpoint task,
if not fix it,
1. very low probability of data loss
2. run `test_path_gc_with_publish_version` case will get err
```
java.sql.SQLException: errCode = 2, detailMessage = (175.40.51.1)[NOT_FOUND]failed to get file size /opt/apache-doris/be/storage/1.HDD/data/22/1745498446653/1868719407/0200000000000019214e72da3f1fe5cfc12
c5efad2bf05bf_0.dat: No such file or directory
```
@deardeng deardeng requested a review from yiguolei as a code owner April 28, 2025 12:48
@deardeng
Copy link
Contributor Author

deardeng commented Apr 28, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Apr 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Apr 28, 2025

BE UT Coverage Report

Increment line coverage 31.67% (19/60) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.84% (10269/26440)
Line Coverage 29.89% (85273/285319)
Region Coverage 28.54% (43952/154000)
Branch Coverage 25.26% (22474/88956)

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 28, 2025

BE Regression P0 && UT Coverage Report

Increment line coverage 86.67% (52/60) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.20% (19330/26050)
Line Coverage 68.98% (195567/283526)
Region Coverage 66.48% (119200/179315)
Branch Coverage 59.57% (59938/100614)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 3660139 into apache:branch-2.1 Apr 29, 2025
20 of 21 checks passed
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Apr 30, 2025
@deardeng
branch-2.1: [fix](path gc) Fix path gc race with publish task apache#…
035cb22 
…50343 (apache#50520)

cherry pick from apache#50343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@deardeng @Thearas @doris-robot @hello-stephen @yiguolei