Skip to content

branch-2.1: [fix](constant fold)Make sure FE cast double to varchar generate identical result with BE. #50425 #50548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Apr 30, 2025
Merged

branch-2.1: [fix](constant fold)Make sure FE cast double to varchar generate identical result with BE. #50425 #50548

yiguolei merged 1 commit into from
Apr 30, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 29, 2025

Cherry-picked from #50425

@Jibing-Li
[fix](constant fold)Make sure FE cast double to varchar generate iden…
77f6d04 
…tical result with BE. (#50425)

### What problem does this PR solve?

BE side use fmt::format_to to cast double to string, FE use
Double.toString(), we need to make sure FE and BE generate identical
cast result:
e.g. 1E10 -> 1e+10, NaN-> nan,  Infinity -> inf
Besides, when the double literal value is larger than 1E16 or less than
-1E16, skip FE side constant folding because we don't know the exact
behavior of fmt::format_to, so skip FE side constant folding and leave
the cast operation to BE.
@github-actions github-actions bot requested a review from yiguolei as a code owner April 29, 2025 09:44
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 29, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Apr 29, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 29, 2025

run buildall

@yiguolei yiguolei merged commit 98be2ce into branch-2.1 Apr 30, 2025
20 checks passed
@github-actions github-actions bot deleted the auto-pick-50425-branch-2.1 branch April 30, 2025 01:17
deardeng pushed a commit to deardeng/incubator-doris that referenced this pull request Apr 30, 2025
@Jibing-Li @github-actions
branch-2.1: [fix](constant fold)Make sure FE cast double to varchar g…
6e42589 
…enerate identical result with BE. apache#50425 (apache#50548) (apache#357)

Cherry-picked from apache#50425

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @yiguolei @dataroaring @Jibing-Li