Skip to content

branch-3.0: [fix](geo) Fix ST_Contains behavior #50115 #50568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
May 6, 2025
Merged

branch-3.0: [fix](geo) Fix ST_Contains behavior #50115 #50568

dataroaring merged 1 commit into from
May 6, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 30, 2025

Cherry-picked from #50115

@linrrzqqq
[fix](geo) Fix ST_Contains behavior (#50115)
d98f461 
1. According to the OGC standard, a point lying exactly on the boundary
of a polygon no longer returns `true` for `ST_Contains`. This behavior
has been changed to return `false`.
2. Fix the inconsistency in `polygon Contains linestring` caused by
differing linestring directions.
3. Fixed a logical error in `multipolygon Contains multipolygon`
@github-actions github-actions bot requested a review from dataroaring as a code owner April 30, 2025 07:29
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Apr 30, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 30, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 30, 2025

BE UT Coverage Report

Increment line coverage 40.00% (14/35) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.50% (10635/26261)
Line Coverage 31.24% (90150/288585)
Region Coverage 30.37% (46545/153249)
Branch Coverage 26.87% (23810/88614)

@linrrzqqq
Copy link
Contributor

linrrzqqq commented Apr 30, 2025

run p0

dataroaring
dataroaring approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit cf9fefe into branch-3.0 May 6, 2025
21 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-50115-branch-3.0 branch May 6, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @linrrzqqq @dataroaring