Skip to content

branch-2.1: [fix](function) fix error result in split_by_string with utf8 chars #40710 #50689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
May 8, 2025
Merged

branch-2.1: [fix](function) fix error result in split_by_string with utf8 chars #40710 #50689

yiguolei merged 1 commit into from
May 8, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 8, 2025

Cherry-picked from #40710

@Mryange
[fix](function) fix error result in split_by_string with utf8 chars (#…
dfd5b87 
…40710)

```
mysql []>select split_by_string('你a好b世c界','');
+-----------------------------------------------------------------------------+
| split_by_string('你a好b世c界', '')                                          |
+-----------------------------------------------------------------------------+
| ["�", "�", "�", "a", "�", "�", "�", "b", "�", "�", "�", "c", "�", "�", "�"]             |
+-----------------------------------------------------------------------------+
1 row in set (0.03 sec)
now
mysql []>select split_by_string('你a好b世c界','');
+---------------------------------------------+
| split_by_string('你a好b世c界', '')          |
+---------------------------------------------+
| ["你", "a", "好", "b", "世", "c", "界"]     |
+---------------------------------------------+
```
@github-actions github-actions bot requested a review from yiguolei as a code owner May 8, 2025 06:15
@hello-stephen
Copy link
Contributor

hello-stephen commented May 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this May 8, 2025
@dataroaring dataroaring reopened this May 8, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented May 8, 2025

run buildall

@doris-robot
Copy link

doris-robot commented May 8, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/31) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.89% (10285/26443)
Line Coverage 29.94% (85432/285371)
Region Coverage 28.60% (44049/154034)
Branch Coverage 25.33% (22535/88972)

@Mryange
Copy link
Contributor

Mryange commented May 8, 2025

run p0

@hello-stephen
Copy link
Contributor

hello-stephen commented May 8, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (31/31) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.44% (19395/26053)
Line Coverage 69.19% (196216/283578)
Region Coverage 66.72% (119670/179349)
Branch Coverage 59.82% (60198/100630)

@yiguolei yiguolei merged commit 1b10860 into branch-2.1 May 8, 2025
18 of 20 checks passed
@github-actions github-actions bot deleted the auto-pick-40710-branch-2.1 branch May 8, 2025 11:16
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 26, 2025
fix(function): fix error result in split_by_string with utf8 chars ap…
2b323bc 
…ache#40710 (apache#50689)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hello-stephen @doris-robot @Mryange @yiguolei @dataroaring