Skip to content

Conversation

@HappenLee
Copy link
Contributor

And Refactor ColumnRangeValue and OlapScanNode

This patch mainly do the following:

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

…A') return error result

[Refactor] Refactor ColumnRangeValue and OlapScanNode

This patch mainly do the following:
- Fix issue apache#5071
- Change type_min in ColumnRangeValue as static
- Add Class of type_limit make code clear
- Refactor the function of normalize_in_and_eq_predicate
@HappenLee HappenLee force-pushed the remove_push_conjuncts branch from e77cafe to fe04f33 Compare December 14, 2020 08:06

std::set<T> result_values;
// 3. fixed_value intersection
if (is_fixed_value_range() || range.is_fixed_value_range()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calculate is_fixed_value_range and range.is_fixed_value_range once.

@HappenLee HappenLee force-pushed the remove_push_conjuncts branch from 298efb1 to 1fe7608 Compare December 14, 2020 11:12
@morningman morningman added the kind/fix Categorizes issue or PR as related to a bug. label Dec 14, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 0a0e46f into apache:master Dec 15, 2020
morningman pushed a commit to baidu-doris/incubator-doris that referenced this pull request Jan 5, 2021
…A') return error result (apache#5072)

And Refactor ColumnRangeValue and OlapScanNode

This patch mainly do the following:
- Fix issue apache#5071
- Change type_min in ColumnRangeValue as static
- Add Class of type_limit make code clear
- Refactor the function of normalize_in_and_eq_predicate
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants