[Bug] Fix a core dump of counter in BE #5078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morningman
added a commit
to baidu-doris/incubator-doris
that referenced
this pull request
Jan 5, 2021
Introduced by PR apache#5051. As @liutang123 said, when PlanFragmentExecutor is destructed, it will call `close -> ExecNode::close -> OlapScanNode::close`. OlapScanNode will wait for `_transfer_thread`. `_transfer_thread` will wait for all OlapScanner processing to complete. OlapScanner is processed by the scanner thread. When the last scanner processing is completed, `_transfer_thread` will break out of the loop, and PlanFragmentExecutor will continue to destruct. And if it is completed, its RuntimeProfile::Counter will also be destructed. At this time, the ScopedTimer in the Scan thread may still use this Counter when it is destructed. So we must make sure that the timer is deconstructed before deconstructing the runtime profile.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Introduced by PR #5051.
As @liutang123 said, when PlanFragmentExecutor is destructed, it will call
close -> ExecNode::close -> OlapScanNode::close. OlapScanNode will wait for_transfer_thread._transfer_threadwill wait for all OlapScanner processing to complete.OlapScanner is processed by the scanner thread. When the last scanner processing is completed,
_transfer_threadwill break out of the loop, and PlanFragmentExecutor will continue to destruct.And if it is completed, its RuntimeProfile::Counter will also be destructed.
At this time, the ScopedTimer in the Scan thread may still use this Counter when it is destructed.
So we must make sure that the timer is deconstructed before deconstructing the runtime profile.
Types of changes