-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feat](refactor-param) refactor brokerLoad's code about fileformat #50882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34291 ms |
TPC-DS: Total hot run time: 193146 ms |
ClickBench: Total hot run time: 29.99 s |
|
run buildall |
TPC-H: Total hot run time: 33898 ms |
TPC-DS: Total hot run time: 185342 ms |
ClickBench: Total hot run time: 29.22 s |
fe/fe-core/src/main/java/org/apache/doris/analysis/DataDescription.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/analysis/DataDescription.java
Outdated
Show resolved
Hide resolved
| getOrigStmt() != null ? getOrigStmt().originStmt : "", copyFromParam.getFileColumns(), | ||
| copyFromParam.getColumnMappingList(), copyFromParam.getFileFilterExpr()); | ||
| } | ||
| dataDescProperties.put(FileFormatProperties.PROP_COMPRESS_TYPE, copyIntoProperties.getCompression()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some format properties in copyIntoProperties. I think we should remove them too. But may be in next PR.
.../src/main/java/org/apache/doris/datasource/property/fileformat/JsonFileFormatProperties.java
Outdated
Show resolved
Hide resolved
|
run buildall |
TPC-H: Total hot run time: 34298 ms |
TPC-DS: Total hot run time: 193435 ms |
ClickBench: Total hot run time: 28.92 s |
|
run buildall |
TPC-H: Total hot run time: 33601 ms |
TPC-DS: Total hot run time: 192319 ms |
ClickBench: Total hot run time: 28.72 s |
|
run buildall |
TPC-H: Total hot run time: 34431 ms |
TPC-DS: Total hot run time: 192903 ms |
ClickBench: Total hot run time: 29.17 s |
|
run buildall |
TPC-H: Total hot run time: 34195 ms |
TPC-DS: Total hot run time: 186551 ms |
ad81c8d to
3a0ecca
Compare
|
run buildall |
TPC-H: Total hot run time: 34076 ms |
TPC-DS: Total hot run time: 195464 ms |
ClickBench: Total hot run time: 29.41 s |
|
run buildall |
TPC-H: Total hot run time: 34440 ms |
TPC-DS: Total hot run time: 185738 ms |
ClickBench: Total hot run time: 29.15 s |
|
run external |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
liaoxin01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…pache#50882) Issue Number:apache#50238 Problem Summary: Previously, we refactored the code of the fileFormat attribute (apache#50225). However, we only added the relevant code without modifying the business code. This pull request modifies the code of the BrokerLoad feature that is related to the fileformat.
…leformat (apache#50882) apache#50882 (cherry picked from commit 0b95a4d)
…pache#50882) Issue Number:apache#50238 Problem Summary: Previously, we refactored the code of the fileFormat attribute (apache#50225). However, we only added the relevant code without modifying the business code. This pull request modifies the code of the BrokerLoad feature that is related to the fileformat.
### What problem does this PR solve? Related PR: #50882
Issue Number:#50238
Problem Summary:
Previously, we refactored the code of the fileFormat attribute (#50225). However, we only added the relevant code without modifying the business code. This pull request modifies the code of the BrokerLoad feature that is related to the fileformat.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)