Skip to content

Conversation

@acelyc111
Copy link
Member

@acelyc111 acelyc111 commented Dec 15, 2020

Proposed changes

There is a bug may cause BE coredump when create tablet, the accessing of tablet_set of a data dir should be protected by lock.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix [Bug] BE coredump when create new tablet #5090), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

@morningman morningman added the kind/fix Categorizes issue or PR as related to a bug. label Dec 15, 2020
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Dec 15, 2020
@morningman morningman merged commit f6881d2 into apache:master Dec 16, 2020
morningman pushed a commit to baidu-doris/incubator-doris that referenced this pull request Jan 5, 2021
There is a bug may cause BE coredump when create tablet,
the accessing of tablet_set of a data dir should be protected by lock.

Change-Id: I63eea6a072fba3848521ceb2f4a53be61c27b950
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
levy5307 pushed a commit to levy5307/incubator-doris that referenced this pull request Nov 14, 2022
There is a bug may cause BE coredump when create tablet,
the accessing of tablet_set of a data dir should be protected by lock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/fix Categorizes issue or PR as related to a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants