-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhance](metrics)add some compaction metrics #50910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34094 ms |
TPC-DS: Total hot run time: 186699 ms |
ClickBench: Total hot run time: 29.37 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
| if (read_stats.hit_cache) { | ||
| statis->num_local_io_total++; | ||
| statis->bytes_read_from_local += read_stats.bytes_read; | ||
| DorisMetrics::instance()->local_compaction_read_bytes_total->increment( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The query path will also go here. This statistic includes the amount of query data read
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there's double counting here. I'll fix it
|
run buildall |
TPC-H: Total hot run time: 34143 ms |
TPC-DS: Total hot run time: 193524 ms |
ClickBench: Total hot run time: 29.03 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 33988 ms |
TPC-DS: Total hot run time: 186361 ms |
ClickBench: Total hot run time: 28.49 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
|
run beut |
|
run external |
|
run buildall |
TPC-H: Total hot run time: 34052 ms |
TPC-DS: Total hot run time: 184388 ms |
ClickBench: Total hot run time: 29.29 s |
|
run buildall |
TPC-H: Total hot run time: 33801 ms |
TPC-DS: Total hot run time: 192388 ms |
ClickBench: Total hot run time: 28.61 s |
|
run beut |
|
PR approved by anyone and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)