Skip to content

Conversation

@weizuo93
Copy link
Contributor

Proposed changes

For the task of rebalancing tablet among different disks on the same BE, It might be an effective strategy to ensure all tablets under the same partition evenly distribute on the different disks. Thus, it is necessary to obtain the distribution of tablets under the same partition between different disks on a BE.

This patch add a new http interface for BE to acquire the distribution of tablets under a partition between different disks on the same BE.

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

@weizuo93 weizuo93 force-pushed the tablets_distribution_be branch from 61df78f to 89ba840 Compare December 17, 2020 06:46
@morningman morningman self-assigned this Jan 12, 2021
@morningman morningman added api-review Categorizes an issue or PR as actively needing an API review. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 12, 2021
```

```
curl -X GET http://be_host:webserver_port/tablets_distribution?partition_id=xxx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
curl -X GET http://be_host:webserver_port/tablets_distributionpartition_id=xxx
curl -X GET http://be_host:webserver_port/tablets_distribution?partition_id=xxx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review.

获取BE节点上每一个partition下的tablet在不同磁盘上的分布情况

```
curl -X GET http://be_host:webserver_port/tablets_distribution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:
/tablets_distribution?group_by=partition
/tablets_distribution?group_by=partition&partition_id=10000

so that we can extent this api in future with some other kind of "group by"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:
/tablets_distribution?group_by=partition
/tablets_distribution?group_by=partition&partition_id=10000

so that we can extent this api in future with some other kind of "group by"?

OK. I will modify the API.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jan 14, 2021
@morningman morningman merged commit 07eaf50 into apache:master Jan 15, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
…tween different disks (apache#5096)

For the task of rebalancing tablet among different disks on the same BE,
It might be an effective strategy to ensure all tablets under the same partition
evenly distribute on the different disks. Thus, it is necessary to obtain the
distribution of tablets under the same partition between different disks on a BE.

This patch add a new http interface for BE to acquire the distribution of tablets
under a partition between different disks on the same BE.
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
@weizuo93 weizuo93 deleted the tablets_distribution_be branch March 9, 2022 07:03
levy5307 pushed a commit to levy5307/incubator-doris that referenced this pull request Nov 14, 2022
…tween different disks (apache#5096)

For the task of rebalancing tablet among different disks on the same BE,
It might be an effective strategy to ensure all tablets under the same partition
evenly distribute on the different disks. Thus, it is necessary to obtain the
distribution of tablets under the same partition between different disks on a BE.

This patch add a new http interface for BE to acquire the distribution of tablets
under a partition between different disks on the same BE.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by one committer. kind/feature Categorizes issue or PR as related to a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants