-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Feature] Add a http interface to acquire the tablets distribution between different disks #5096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
61df78f to
89ba840
Compare
| ``` | ||
|
|
||
| ``` | ||
| curl -X GET http://be_host:webserver_port/tablets_distribution?partition_id=xxx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| curl -X GET http://be_host:webserver_port/tablets_distribution?partition_id=xxx | |
| curl -X GET http://be_host:webserver_port/tablets_distribution?partition_id=xxx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review.
| 获取BE节点上每一个partition下的tablet在不同磁盘上的分布情况 | ||
|
|
||
| ``` | ||
| curl -X GET http://be_host:webserver_port/tablets_distribution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
/tablets_distribution?group_by=partition
/tablets_distribution?group_by=partition&partition_id=10000
so that we can extent this api in future with some other kind of "group by"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
/tablets_distribution?group_by=partition
/tablets_distribution?group_by=partition&partition_id=10000so that we can extent this api in future with some other kind of "group by"?
OK. I will modify the API.
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…tween different disks (apache#5096) For the task of rebalancing tablet among different disks on the same BE, It might be an effective strategy to ensure all tablets under the same partition evenly distribute on the different disks. Thus, it is necessary to obtain the distribution of tablets under the same partition between different disks on a BE. This patch add a new http interface for BE to acquire the distribution of tablets under a partition between different disks on the same BE.
…tween different disks (apache#5096) For the task of rebalancing tablet among different disks on the same BE, It might be an effective strategy to ensure all tablets under the same partition evenly distribute on the different disks. Thus, it is necessary to obtain the distribution of tablets under the same partition between different disks on a BE. This patch add a new http interface for BE to acquire the distribution of tablets under a partition between different disks on the same BE.
Proposed changes
For the task of rebalancing tablet among different disks on the same BE, It might be an effective strategy to ensure all tablets under the same partition evenly distribute on the different disks. Thus, it is necessary to obtain the distribution of tablets under the same partition between different disks on a BE.
This patch add a new http interface for BE to acquire the distribution of tablets under a partition between different disks on the same BE.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.