-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[refine](DataTypeSerDe) Remove the level variable from FormatOptions and use _nesting_level. #50977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 33814 ms |
TPC-DS: Total hot run time: 186478 ms |
ClickBench: Total hot run time: 29.67 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…and use _nesting_level. (apache#50977) We don't need to maintain a separate level; we can achieve the functionality of this apache#49036 by directly using _nesting_level. ```C++ // This parameter indicates what level the serde belongs to and is mainly used for complex types // The default level is 1, and each time you nest, the level increases by 1, // for example: struct<string> // The _nesting_level of StructSerde is 1 // The _nesting_level of StringSerde is 2 int _nesting_level = 1; ```
What problem does this PR solve?
We don't need to maintain a separate level; we can achieve the functionality of this #49036 by directly using _nesting_level.
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)