Skip to content

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented May 16, 2025

What problem does this PR solve?

We don't need to maintain a separate level; we can achieve the functionality of this #49036 by directly using _nesting_level.

    // This parameter indicates what level the serde belongs to and is mainly used for complex types
    // The default level is 1, and each time you nest, the level increases by 1,
    // for example: struct<string>
    // The _nesting_level of StructSerde is 1
    // The _nesting_level of StringSerde is 2
    int _nesting_level = 1;

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented May 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented May 16, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33814 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b04462aa3c9d688521ddb1a7424165a82d399ee0, data reload: false

------ Round 1 ----------------------------------
q1	26381	5062	4990	4990
q2	2109	312	205	205
q3	10474	1286	695	695
q4	10250	1038	533	533
q5	7798	2591	2307	2307
q6	187	165	133	133
q7	917	744	613	613
q8	9316	1320	1136	1136
q9	6829	5122	5090	5090
q10	6828	2325	1866	1866
q11	487	302	278	278
q12	355	355	214	214
q13	17772	3739	3108	3108
q14	247	242	219	219
q15	534	486	488	486
q16	422	435	378	378
q17	623	880	379	379
q18	7489	7293	7115	7115
q19	2488	974	550	550
q20	330	351	225	225
q21	3864	3215	2337	2337
q22	1053	992	957	957
Total cold run time: 116753 ms
Total hot run time: 33814 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5171	5043	5041	5041
q2	244	331	235	235
q3	2183	2655	2345	2345
q4	1320	1763	1527	1527
q5	4540	4465	4267	4267
q6	210	167	125	125
q7	2021	1944	1738	1738
q8	2573	2654	2606	2606
q9	7094	7206	7293	7206
q10	2997	3166	2746	2746
q11	581	499	498	498
q12	693	779	616	616
q13	3536	3865	3493	3493
q14	271	287	280	280
q15	515	478	467	467
q16	446	498	452	452
q17	1152	1525	1374	1374
q18	7726	7646	7485	7485
q19	792	807	896	807
q20	1974	2059	1823	1823
q21	4764	4370	4323	4323
q22	1060	1028	984	984
Total cold run time: 51863 ms
Total hot run time: 50438 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186478 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b04462aa3c9d688521ddb1a7424165a82d399ee0, data reload: false

query1	998	491	491	491
query2	6558	1883	1848	1848
query3	6762	222	211	211
query4	26102	23762	23670	23670
query5	4942	618	444	444
query6	291	197	185	185
query7	4623	495	300	300
query8	332	244	237	237
query9	8654	2692	2685	2685
query10	511	360	283	283
query11	15671	15020	14793	14793
query12	173	114	106	106
query13	1658	552	434	434
query14	9643	6146	6120	6120
query15	208	193	176	176
query16	7419	627	475	475
query17	1156	722	573	573
query18	1993	425	304	304
query19	194	187	172	172
query20	123	120	123	120
query21	218	130	110	110
query22	4288	4424	4296	4296
query23	34301	33133	33278	33133
query24	8374	2406	2388	2388
query25	537	465	385	385
query26	1251	276	158	158
query27	2735	503	340	340
query28	4290	2142	2125	2125
query29	746	567	432	432
query30	282	217	189	189
query31	964	864	751	751
query32	70	62	62	62
query33	542	387	321	321
query34	789	841	526	526
query35	784	806	766	766
query36	972	987	877	877
query37	111	98	76	76
query38	4161	4063	4047	4047
query39	1487	1390	1408	1390
query40	212	121	104	104
query41	72	53	54	53
query42	136	109	106	106
query43	511	507	481	481
query44	1311	827	820	820
query45	179	170	165	165
query46	841	1004	634	634
query47	1771	1793	1726	1726
query48	383	433	314	314
query49	774	501	432	432
query50	652	669	406	406
query51	4111	4137	4047	4047
query52	113	107	99	99
query53	221	248	186	186
query54	605	569	500	500
query55	94	81	88	81
query56	293	300	281	281
query57	1136	1162	1086	1086
query58	276	265	264	264
query59	2583	2755	2554	2554
query60	335	339	298	298
query61	125	124	118	118
query62	795	755	664	664
query63	216	188	189	188
query64	4294	1011	664	664
query65	4361	4235	4227	4227
query66	1120	465	314	314
query67	15791	15694	15555	15555
query68	8116	885	521	521
query69	463	300	271	271
query70	1209	1155	1079	1079
query71	498	316	301	301
query72	5797	4690	4655	4655
query73	733	596	354	354
query74	9281	9005	8704	8704
query75	3736	3183	2676	2676
query76	3695	1173	765	765
query77	790	382	305	305
query78	9935	10030	9465	9465
query79	2860	816	587	587
query80	629	504	434	434
query81	481	253	217	217
query82	440	123	95	95
query83	282	254	230	230
query84	298	105	90	90
query85	784	353	315	315
query86	339	336	286	286
query87	4415	4415	4234	4234
query88	2913	2302	2305	2302
query89	413	303	289	289
query90	1972	211	204	204
query91	185	145	110	110
query92	78	62	59	59
query93	1660	921	577	577
query94	672	418	307	307
query95	372	283	284	283
query96	505	574	282	282
query97	2776	2821	2616	2616
query98	231	211	202	202
query99	1435	1406	1297	1297
Total cold run time: 276217 ms
Total hot run time: 186478 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.67 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b04462aa3c9d688521ddb1a7424165a82d399ee0, data reload: false

query1	0.04	0.03	0.04
query2	0.13	0.11	0.11
query3	0.25	0.20	0.19
query4	1.60	0.20	0.20
query5	0.47	0.44	0.44
query6	1.16	0.66	0.66
query7	0.03	0.01	0.02
query8	0.04	0.03	0.04
query9	0.58	0.53	0.53
query10	0.56	0.59	0.57
query11	0.16	0.10	0.11
query12	0.15	0.11	0.12
query13	0.61	0.59	0.59
query14	0.78	0.82	0.81
query15	0.88	0.87	0.85
query16	0.39	0.38	0.38
query17	1.02	1.04	1.04
query18	0.22	0.22	0.21
query19	1.93	1.83	1.78
query20	0.01	0.01	0.02
query21	15.48	0.97	0.53
query22	0.76	1.26	1.06
query23	14.70	1.30	0.64
query24	7.42	1.86	1.00
query25	0.46	0.15	0.06
query26	0.60	0.16	0.15
query27	0.05	0.05	0.04
query28	9.74	0.85	0.45
query29	12.53	3.97	3.30
query30	0.25	0.10	0.07
query31	2.83	0.57	0.39
query32	3.24	0.54	0.48
query33	3.08	3.04	3.06
query34	15.83	5.11	4.55
query35	4.49	4.47	4.56
query36	0.67	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.09	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.64 s
Total hot run time: 29.67 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 55.87% (14883/26641)
Line Coverage 44.65% (131871/295364)
Region Coverage 43.76% (66394/151734)
Branch Coverage 38.35% (34017/88694)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.52% (20857/26228)
Line Coverage 72.66% (214633/295375)
Region Coverage 70.84% (126300/178290)
Branch Coverage 64.60% (65452/101326)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 20, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 60ee1a8 into apache:master May 21, 2025
27 of 29 checks passed
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…and use _nesting_level. (apache#50977)

We don't need to maintain a separate level; we can achieve the
functionality of this apache#49036 by
directly using _nesting_level.

```C++
    // This parameter indicates what level the serde belongs to and is mainly used for complex types
    // The default level is 1, and each time you nest, the level increases by 1,
    // for example: struct<string>
    // The _nesting_level of StructSerde is 1
    // The _nesting_level of StringSerde is 2
    int _nesting_level = 1;
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants