-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](MTMV) mtmv not refresh cache of external table before run task #50979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34090 ms |
TPC-DS: Total hot run time: 193151 ms |
ClickBench: Total hot run time: 29.17 s |
zddr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also should change org.apache.doris.datasource.hive.HMSExternalTable#beforeMTMVRefresh ?
|
run buildall |
TPC-H: Total hot run time: 33753 ms |
TPC-DS: Total hot run time: 186056 ms |
ClickBench: Total hot run time: 28.93 s |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
zddr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TPC-H: Total hot run time: 33970 ms |
TPC-DS: Total hot run time: 185528 ms |
ClickBench: Total hot run time: 29.1 s |
…pache#50979) Problem Summary: related pr: apache#48172 This pr(apache#48172) had changed the code logical of method `beforeMTMVRefresh`, but this pr(apache#49956) added the code back. So we delete this code.
…pache#50979) Problem Summary: related pr: apache#48172 This pr(apache#48172) had changed the code logical of method `beforeMTMVRefresh`, but this pr(apache#49956) added the code back. So we delete this code.
…pache#50979) Problem Summary: related pr: apache#48172 This pr(apache#48172) had changed the code logical of method `beforeMTMVRefresh`, but this pr(apache#49956) added the code back. So we delete this code.
Problem Summary:
related pr: #48172
This pr(#48172) had changed the code logical of method
beforeMTMVRefresh, but this pr(#49956) added the code back.So we delete this code.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)