-
Notifications
You must be signed in to change notification settings - Fork 3.7k
branch-3.0: [feat](hive) add catalog level schema cache property #50958 #51057 #51011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What problem does this PR solve? Problem Summary: Just same as #50724, support enable or disable schema cache at Catalog level for all kinds of external catalogs. Previously, if user want to disable the schema cache, they can only set the `max_external_schema_cache_num=0` in fe.conf and restart FE. And this config will effect all catalogs. In this PR, I add a new catalog property `schema.cache.ttl-second`. If set to 0, the schema cache will be disabled, so if schema is changed Doris will read the new schema immediately.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
TPC-H: Total hot run time: 39801 ms |
TPC-DS: Total hot run time: 198549 ms |
ClickBench: Total hot run time: 31.74 s |
Contributor
|
Do not merge now |
…get_schema_from_table" mode (#51057) Related PR: #50958 Problem Summary: In #50958, I introduced the catalog level schema cache switch. But if use also add `"get_schema_from_table" = "true"`, the schema will be fetched from `Hive Table` instead of schema cache, so the schema cache config is broken. This PR fix it: 1. Always get new `Hive Table` instance to get schema from table. To make schema change config work. 2. For `show create table xxx`, it will always show the latest schema of a hive table.
Contributor
|
run buildall |
TPC-H: Total hot run time: 39773 ms |
TPC-DS: Total hot run time: 196144 ms |
ClickBench: Total hot run time: 30.56 s |
dataroaring
approved these changes
Jun 24, 2025
Contributor
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #50958 #51057