[Enhancement] Add more comprehensive prometheus jvm thread metrics on fe #5112
Conversation
| Threads threads = jvmStats.getThreads(); | ||
| result.addRow(genRow("threads count", threads.getCount())); | ||
| result.addRow(genRow("threads peak count", threads.getPeakCount())); | ||
| result.addRow(genRow("threads new count", threads.getThreadsNewCount())); |
There was a problem hiding this comment.
Please update docs of fe metrics include every new metrics and means of metrics
There was a problem hiding this comment.
Jvm Thread State is an enum type. A thread can be in one of the following states: NEW, RUNNABLE, BLOCKED, WAITING, TIMED_WAITING, TERMINATED.
A fe thread can be in only one state at a given point in time. The new metrics mean how many fe threads in a specific state now. I think this will be useful when we want to analysis fe whole running status.
There was a problem hiding this comment.
Currently, the docs about metrics contains PrometheusMetrics and SystemMetrics. The doris_fe_snmp belong to SystemMetrics, and the new metrics I added belong to PrometheusMetrics. I want to confirm did I need to add new metrics in this page?
There was a problem hiding this comment.
It is ok to add them in this doc.
we will reorganized this doc later.
There was a problem hiding this comment.
Thank you for your reply. I have update the docs of fe metrics.
… fe (apache#5112) Currently, fe thread metrics is very simple, only have thread count and peak_count. I think we may need more comprehensive prometheus jvm thread metrics on fe. This will be useful when we want to analysis fe's running status.
3 participants
Proposed changes
Currently, fe thread metrics is very simple, only have thread count and peak_count. I think we may need more comprehensive prometheus jvm thread metrics on fe. This will be useful when we want to analysis fe's running status.
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...