-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feat](storage vault) Check storage vault connectivity for BE when starting #51175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 33831 ms |
TPC-DS: Total hot run time: 192368 ms |
ClickBench: Total hot run time: 29.11 s |
d85e6a1 to
c423f1a
Compare
|
run buildall |
TPC-H: Total hot run time: 33893 ms |
TPC-DS: Total hot run time: 192794 ms |
ClickBench: Total hot run time: 28.99 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 33682 ms |
TPC-DS: Total hot run time: 192980 ms |
ClickBench: Total hot run time: 29.71 s |
|
run buildall |
TPC-H: Total hot run time: 33645 ms |
TPC-DS: Total hot run time: 193220 ms |
ClickBench: Total hot run time: 29.49 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 33862 ms |
TPC-DS: Total hot run time: 193134 ms |
ClickBench: Total hot run time: 29.2 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…arting (#51175) In storage vault mode during `BE` startup, if an aws role arn s3 vault is detected, we will check if the machine which `BE` deployed has been configured correctly. it will not allow `BE` starting if configuration is incorrect.
…arting (#51175) In storage vault mode during `BE` startup, if an aws role arn s3 vault is detected, we will check if the machine which `BE` deployed has been configured correctly. it will not allow `BE` starting if configuration is incorrect.
* apache#51175 introduced a deadlock problem: 1. the `sync_storage_vault()` func wait for heartbeat thread to set config::meta_service_endpoint 2. the heartbeat thread wait for the `sync_storage_vault()` func success to start
* apache#51175 introduced a deadlock problem: 1. the `sync_storage_vault()` func wait for heartbeat thread to set config::meta_service_endpoint 2. the heartbeat thread wait for the `sync_storage_vault()` func success to start
* #51175 introduced a deadlock problem: 1. the `sync_storage_vault()` func wait for heartbeat thread to set config::meta_service_endpoint 2. the heartbeat thread wait for the `sync_storage_vault()` func success to start
* #51175 introduced a deadlock problem: 1. the `sync_storage_vault()` func wait for heartbeat thread to set config::meta_service_endpoint 2. the heartbeat thread wait for the `sync_storage_vault()` func success to start
* #51175 introduced a deadlock problem: 1. the `sync_storage_vault()` func wait for heartbeat thread to set config::meta_service_endpoint 2. the heartbeat thread wait for the `sync_storage_vault()` func success to start
…r BE when starting apache#51175 (apache#52319) Cherry-picked from apache#51175 Co-authored-by: Lei Zhang <zhanglei@selectdb.com>
* apache#51175 introduced a deadlock problem: 1. the `sync_storage_vault()` func wait for heartbeat thread to set config::meta_service_endpoint 2. the heartbeat thread wait for the `sync_storage_vault()` func success to start
* apache#51175 introduced a deadlock problem: 1. the `sync_storage_vault()` func wait for heartbeat thread to set config::meta_service_endpoint 2. the heartbeat thread wait for the `sync_storage_vault()` func success to start
* apache#51175 introduced a deadlock problem: 1. the `sync_storage_vault()` func wait for heartbeat thread to set config::meta_service_endpoint 2. the heartbeat thread wait for the `sync_storage_vault()` func success to start
In storage vault mode during
BEstartup, if an aws role arn s3 vault is detected, we will check if the machine whichBEdeployed has been configured correctly. it will not allowBEstarting if configuration is incorrect.What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)