Skip to content

Conversation

@xinghuayu007
Copy link
Contributor

Proposed changes

When query uses bucket join, fuction Coordinator#BucketShuffleJoinController#getExecHostPortForFragmentIDAndBucketSeq is responseful for making sure each host have average bucket to scan. That means if there are 10 buckets to scan and 5 hosts, the strategy will distributed 2 buckets to each host. The algorithm is like this:

a. use data structure buckendIdToBucketCountMap to represents how many buckets distributed to the backend;
b. traverse every backend, find a backend which owns minimum buckets. We call it mini_backend;
c. distribute the bucket to the mini_backend;
d. update buckendIdToBucketCountMap for mini_backend;

When all bakends are all alive, the algorithm is available. But when mini_backend is not alive, it will chose a replica host as final host randomly and buckendIdToBucketCountMap is not updated. This will cause the bucket scan task not load balance.

This patch optimize the algorithm. When the mini_backend is not alive, update buckendIdToBucketCountMap.

Related Issue: #5132

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

wangxixu added 30 commits August 13, 2020 22:09
if (!buckendIdToBucketCountMap.containsKey(backendIdRef.getRef())) {
buckendIdToBucketCountMap.put(backendIdRef.getRef(), 1);
} else {
buckendIdToBucketCountMap.put(backendIdRef.getRef(), buckendIdToBucketCountMap.get(backendIdRef.getRef())+1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
buckendIdToBucketCountMap.put(backendIdRef.getRef(), buckendIdToBucketCountMap.get(backendIdRef.getRef())+1);
buckendIdToBucketCountMap.put(backendIdRef.getRef(), buckendIdToBucketCountMap.get(backendIdRef.getRef()) + 1);

caiconghui
caiconghui previously approved these changes Dec 25, 2020
Copy link
Contributor

@caiconghui caiconghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caiconghui caiconghui added the approved Indicates a PR has been approved by one committer. label Dec 25, 2020
@morningman
Copy link
Contributor

@xinghuayu007 there are conflict, please resolve them first.

@xinghuayu007 xinghuayu007 force-pushed the bucket_optimize_score branch 2 times, most recently from 233aee7 to 409a359 Compare December 31, 2020 02:42
@xinghuayu007
Copy link
Contributor Author

@xinghuayu007 there are conflict, please resolve them first.

Thank you for your code review. The conflict has been resolved.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kangkaisen kangkaisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kangkaisen kangkaisen merged commit 1035e86 into apache:master Jan 6, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants